Skip to content

Conversation

@laeubi
Copy link
Contributor

@laeubi laeubi commented Jul 8, 2025

Currently the first thing a reconciler after startup does is to sleep for a while then call initialProcess then start the processing loop (that sleeps again...).

This now moves this initial work into the start job so we have a plain processing loop in the thread to make further improvements easier.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

Test Results

 2 778 files  ±0   2 778 suites  ±0   1h 38m 47s ⏱️ + 5m 11s
 7 930 tests ±0   7 700 ✅  - 2  228 💤 ±0  2 ❌ +2 
23 345 runs  ±0  22 597 ✅  - 2  746 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit f46fb35. ± Comparison against base commit f41ea06.

♻️ This comment has been updated with latest results.

@iloveeclipse
Copy link
Member

I'm not sure if that change would not break the implementation of existing clients, the code is very old to there is ahigh probability someone extended it.

BackgroundThread.run() javadoc says that it will call initialProcess() and that was always done in the BackgroundThread. Now with this change the code will run in a different thread.

@laeubi laeubi force-pushed the us_jobmanager_for_inital branch from 35efdd5 to fc5a895 Compare July 9, 2025 08:04
@laeubi
Copy link
Contributor Author

laeubi commented Jul 9, 2025

BackgroundThread.run() javadoc says that it will call initialProcess() and that was always done in the BackgroundThread. Now with this change the code will run in a different thread.

I think that is more it run in a background thread than in the BackgroundThread ... to prevent confusion I renamed that class now and don't let it implement Thread but instead creating one. I also adjuste the code so anyone that needs to know that it is inside the reconcile background thread can still query it using AbstractReconciler.isRunningInReconcilerThread() that is the only place an implementation can actually hook in / extend anything.

@laeubi laeubi force-pushed the us_jobmanager_for_inital branch 5 times, most recently from 92b8e0f to 25b8296 Compare July 9, 2025 08:26
Currently the first thing a reconciler after startup does is to sleep
for a while then call initialProcess then start the processing loop
(that sleeps again...).

This now moves this initial work into the start job so we have a plain
processing loop in the thread to make further improvements easier.
@laeubi laeubi force-pushed the us_jobmanager_for_inital branch from 25b8296 to f46fb35 Compare July 10, 2025 09:39
@laeubi laeubi merged commit 0e4942b into eclipse-platform:master Jul 11, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants