-
Notifications
You must be signed in to change notification settings - Fork 228
Add scope changed notification to SearchDialog #3097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jjohnstn
commented
Jul 8, 2025
- add new IScopeChangedListener, IScopeChangeProvider, ScopeChangedEvent classes
- have SearchDialog implement new IScopeChangeProvider
- bump up minor version with new public interfaces
- fixes allow scope selection changes to be listened for #3096
- add new IScopeChangedListener, IScopeChangeProvider, ScopeChangedEvent classes - have SearchDialog implement new IScopeChangeProvider - bump up minor version with new public interfaces - fixes eclipse-platform#3096
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Test Results 2 764 files - 14 2 764 suites - 14 1h 44m 41s ⏱️ + 11m 5s For more details on these failures, see this check. Results for commit 532116b. ± Comparison against base commit f41ea06. This pull request skips 5 tests.♻️ This comment has been updated with latest results. |
|
@akurtakov Could you look at this? |
|
I had a quick look on my phone and it looks fine. |
bundles/org.eclipse.search/search/org/eclipse/search/internal/ui/SearchDialog.java
Outdated
Show resolved
Hide resolved
fedejeanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just have some suggestions
bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/IScopeChangedListener.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/ScopeChangedEvent.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.search/search/org/eclipse/search/internal/ui/SearchDialog.java
Outdated
Show resolved
Hide resolved
…ChangedListener.java Co-authored-by: Federico Jeanne <[email protected]>
…ui/SearchDialog.java Co-authored-by: Patrick Ziegler <[email protected]>
…hangedEvent.java Co-authored-by: Federico Jeanne <[email protected]>
|
/rebuild |
|
We seem to be having issues again: https://github.com/orgs/eclipse-simrel/discussions/921#discussioncomment-13713782 I kicked another build. 🤞 But now it's late... |
|
Test failure is unrelated: #2708 |