Skip to content

Conversation

@jjohnstn
Copy link
Contributor

@jjohnstn jjohnstn commented Jul 8, 2025

jjohnstn and others added 2 commits July 8, 2025 14:13
- add new IScopeChangedListener, IScopeChangeProvider,
  ScopeChangedEvent classes
- have SearchDialog implement new IScopeChangeProvider
- bump up minor version with new public interfaces
- fixes eclipse-platform#3096
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.search/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From c4c1ebb463ad047e61148f3b87b4efc44712e6f5 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Tue, 8 Jul 2025 18:22:52 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/bundles/org.eclipse.search/META-INF/MANIFEST.MF b/bundles/org.eclipse.search/META-INF/MANIFEST.MF
index fcfd9d845d..001a2b22bf 100644
--- a/bundles/org.eclipse.search/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.search/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.search; singleton:=true
-Bundle-Version: 3.17.200.qualifier
+Bundle-Version: 3.17.300.qualifier
 Bundle-Activator: org.eclipse.search.internal.ui.SearchPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

Test Results

 2 764 files   - 14   2 764 suites   - 14   1h 44m 41s ⏱️ + 11m 5s
 7 930 tests ± 0   7 696 ✅  -  6  233 💤 +5  1 ❌ +1 
23 300 runs   - 45  22 553 ✅  - 46  746 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 532116b. ± Comparison against base commit f41ea06.

This pull request skips 5 tests.
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testEnabledWhenHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testMultipleHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testProblemHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testSingleHover
org.eclipse.ui.genericeditor.tests.ShowInformationTest ‑ testInformationControl

♻️ This comment has been updated with latest results.

@jjohnstn
Copy link
Contributor Author

jjohnstn commented Jul 8, 2025

@akurtakov Could you look at this?

@merks
Copy link
Contributor

merks commented Jul 8, 2025

I had a quick look on my phone and it looks fine.

Copy link
Member

@fedejeanne fedejeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have some suggestions

@jjohnstn
Copy link
Contributor Author

jjohnstn commented Jul 9, 2025

/rebuild

@merks
Copy link
Contributor

merks commented Jul 9, 2025

We seem to be having issues again:

https://github.com/orgs/eclipse-simrel/discussions/921#discussioncomment-13713782

I kicked another build. 🤞 But now it's late...

@fedejeanne
Copy link
Member

Test failure is unrelated: #2708

@fedejeanne fedejeanne merged commit 789b373 into eclipse-platform:master Jul 14, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow scope selection changes to be listened for

5 participants