Skip to content

Deleted code minings in invisible area need to be redrawn #3154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deleted code minings in invisible area need to be redrawn #3154

wants to merge 1 commit into from

Conversation

tobiasmelcher
Copy link
Contributor

@tobiasmelcher tobiasmelcher commented Aug 8, 2025 •
edited
Loading

so that StyleRange and LineVerticalIndent on StyledText control are removed.
Fixes #3120

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025 •
edited
Loading

Test Results

 2 778 files  ±0   2 778 suites  ±0   1h 40m 47s ⏱️ - 2m 5s
 7 934 tests +1   7 703 ✅  - 1  229 💤 ±0  2 ❌ +2 
23 343 runs  +3  22 604 ✅ +1  737 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 26648f0. ± Comparison against base commit c496bbc.

♻️ This comment has been updated with latest results.

@tobiasmelcher tobiasmelcher force-pushed the invisible_region branch 4 times, most recently from 00ba060 to f4a08a2 Compare August 12, 2025 11:08
@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Aug 12, 2025 •
edited
Loading

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

tests/org.eclipse.ui.genericeditor.tests/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From ae032e7a31cddcb940d30abde049918eee4cd9c9 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Tue, 12 Aug 2025 12:34:09 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/tests/org.eclipse.ui.genericeditor.tests/META-INF/MANIFEST.MF b/tests/org.eclipse.ui.genericeditor.tests/META-INF/MANIFEST.MF
index c7a166b53c..db3beb1d6e 100644
--- a/tests/org.eclipse.ui.genericeditor.tests/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.ui.genericeditor.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.genericeditor.tests;singleton:=true
-Bundle-Version: 1.3.800.qualifier
+Bundle-Version: 1.3.900.qualifier
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
 Export-Package: org.eclipse.ui.genericeditor.tests,
-- 
2.50.1

Further information are available in Common Build Issues - Missing version increments.

@BeckerWdf BeckerWdf mentioned this pull request Aug 14, 2025
Open
2 tasks
BeckerWdf
BeckerWdf reviewed Aug 14, 2025
View reviewed changes
.../org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/PartRenderingEngineTests.java Outdated
while (partStackForPartBPartC.isToBeRendered()) {
contextRule.spinEventLoop();
long diff = System.currentTimeMillis() - startTime;
if (diff > 60_000) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really want to wait for 60 second?
Can this be improved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reduced the timeout to 5 seconds and switched to DisplayHelper.waitForCondition with [26648f0]

@BeckerWdf
Copy link
Contributor

@tobiasmelcher Can you pls. resolve the conflicts?

@tobias-melcher
Deleted code minings in invisible area need to be redrawn
26648f0 
so that StyleRange and LineVerticalIndent on StyledTexxt control are
removed. Fixes
eclipse-platform#3120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeckerWdf BeckerWdf BeckerWdf left review comments

@mickaelistria mickaelistria Awaiting requested review from mickaelistria

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The line vertical indentation will not reset when removing multi-line code mining text out of the viewport
4 participants
@tobiasmelcher @eclipse-platform-bot @BeckerWdf @tobias-melcher