Allowing smaller images to show in the workbench window

[andrew-tram]

Proposed solution for #3069

Currently, the code decides whether to show the onboarding image using a fixed threshold (ONBOARDING_SHOW_IMAGE_HEIGHT_THRESHOLD, 450px content height), regardless of the actual image size.

My idea is to make this more adaptive by retrieve the actual image height from the label.

If the image is small (<= 250px), allow it to be shown with a lower overall height requirement (e.g., 314px total window height).
If the image is large (> 250px), keep using the existing higher threshold.

Also, from the extension point descrption:

The image is shown in the editor area in case no editor is open.
The image shall be grey and not colored and shall have a size of 250 x 250 px.
Plus a second image for high resolution with a size of 500 x 500 px and a name like [image_name]@2x.[image_type].

I dont really see it take into account the @2x size for an image, so when I manually use a 500x500 image, it gets cut off anyway because of the 450 threshold. But maybe I dont know how to trigger the @2x resolution in Eclipse properly.

[andrew-tram]

Hey all, looking for feedback and review on this PR.

[HeikoKlare]

Sound like a reasonable intermediate solution until we have:

• Use SVG scaling and disabled image generation for Onboarding Image #3098

@marcushoepfner this is probably most interesting for you and particularly interesting to have your opinion

[BeckerWdf]

@marcushoepfner currently is on vacation. So he will not be able to react here in a timely manner.

[HeikoKlare]

Thanks for the info! I guess it's not a problem as this cannot go into the upcoming release anymore anyway, so we basically have time until November to finalize it for the December release.

[BeckerWdf]

Thanks for the info! I guess it's not a problem as this cannot go into the upcoming release anymore anyway, so we basically have time until November to finalize it for the December release.

Yes I agree that this is not a problem. Just wanted to set expectations.