Add DnD tests issue #3182 #3195
Open
+1,151
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merks
requested changes
Aug 17, 2025
Comment on lines
+1
to
+11
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <projectDescription> | ||
| <name>features</name> | ||
| <comment></comment> | ||
| <projects> | ||
| </projects> | ||
| <buildSpec> | ||
| </buildSpec> | ||
| <natures> | ||
| </natures> | ||
| </projectDescription> |
There was a problem hiding this comment.
Adding a .project file here is not needed and not desired.
Comment on lines
+1
to
+13
| /******************************************************************************* | ||
| * Copyright (c) 2004, 2005 IBM Corporation and others. | ||
| * | ||
| * This program and the accompanying materials | ||
| * are made available under the terms of the Eclipse Public License 2.0 | ||
| * which accompanies this distribution, and is available at | ||
| * https://www.eclipse.org/legal/epl-2.0/ | ||
| * | ||
| * SPDX-License-Identifier: EPL-2.0 | ||
| * | ||
| * Contributors: | ||
| * IBM Corporation - initial API and implementation | ||
| *******************************************************************************/ |
There was a problem hiding this comment.
I guess you copied this from somewhere.
| @@ -0,0 +1,26 @@ | |||
| package org.eclipse.ui.tests.dnd; | |||
There was a problem hiding this comment.
Every java file needs a "standard" copyright header.
|
|
||
| IEditorPart editor1, editor2, editor3; | ||
|
|
||
| static WorkbenchWindow window; |
There was a problem hiding this comment.
Can this be an IWorkbenchWindow? Should any of these things really be static?
| IEditorPart editor1, editor2, editor3; | ||
|
|
||
| static WorkbenchWindow window; | ||
| static WorkbenchPage page; |
There was a problem hiding this comment.
Can this be an IWorkbenchPage?
| continue; | ||
| } | ||
|
|
||
| DragTest newTest = new DragTest(dragSource, dropTarget); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.