Fix caret of raw insert mode of text editor on HiDPI screens #3230
Conversation
Test Results 3 018 files 3 018 suites 2h 18m 22s ⏱️ Results for commit 7243492. ♻️ This comment has been updated with latest results. |
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Thank you for proposing this fix! I have one question regarding the proposed solution, as it appears more complex to me than required.
|
|
||
| return bracketImage; | ||
| int height= styledText.getLineHeight(); | ||
| return new Image(styledText.getDisplay(), new ImageDataProvider() { |
There was a problem hiding this comment.
Is there any reason to use an ImageDataProvider rather than an ImageGcDrawer?
This requires to manually implement proper line width calculation and line rendering instead of just using gc.drawLine() like in the original code.
There was a problem hiding this comment.
This creates a 1-bit image as before.
There was a problem hiding this comment.
What do you mean with "1-bit image"? Do you mean that the line is 1 pixel wide? That's the intended behavior of setLineWidth(0). Changing that to setLineWidth(1) should resolve it.
There was a problem hiding this comment.
1-bit image = image with 1-bit color palette = a pixels uses 1-bit = colloquially called black-and-white image
There was a problem hiding this comment.
I see. But is it really necessary/beneficial to keep it like that?
2 participants
Fixes: #3010