Junit5 test suites updates #3341
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogella
force-pushed
the
junit5-test-suites-updates
branch
from
b16e170 to
bf57e8e
Compare
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
vogella
force-pushed
the
junit5-test-suites-updates
branch
from
92050ad to
3cddb42
Compare
Contributor
Test Results 3 018 files +114 3 018 suites +114 2h 22m 51s ⏱️ + 23m 15s For more details on these failures, see this check. Results for commit f9f0149. ± Comparison against base commit 27438b5. This pull request removes 5859 and adds 6055 tests. Note that renamed tests count towards both.This pull request removes 117 skipped tests and adds 121 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Contributor
|
This seems to be the third PR migrating test suites to JUnit 5 after:
The one migrating the complete |
- Convert @RunWith(Suite.class) to @suite - Convert @Suite.SuiteClasses to @SelectClasses - Update imports from org.junit.runners to org.junit.platform.suite.api - Add org.junit.jupiter.api and org.junit.platform.suite.api to Import-Package in all 22 affected test bundles Created by Copilot for testing AI based contributions.
vogella
force-pushed
the
junit5-test-suites-updates
branch
from
3cddb42 to
f9f0149
Compare
Contributor
Author
|
@HeikoKlare looks fine, except the macOS failure, but IIRC macOS is always a bit flacky. What do you think? Shall I still split it up by project? This would be fine for me, I would ask Copilot CLI to do this for me. ;-) |
Contributor
Author
|
Forgot to write: Jenkins build failure seems also unrelated 14:51:03.306 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.12.0:jar (attach-javadocs) on project org.eclipse.core.databinding.property: MavenReportException: Error while generating Javadoc: |
Contributor
I am a bit concerned about this PR being a superset of #3246 and that PR sporadically showing a bunch of test failures, e.g., in this run: https://github.com/eclipse-platform/eclipse.platform.ui/pull/3246/checks?check_run_id=51308876219 I currently don't see what is different in this PR such that those failures should not occur when merging this PR. That's why I would be in favor of splitting it up into incrementally migrating subsets of the projects and have several builds hopefully succeeding afterwards to be sure that everything is stable before merging the next bunch of project migrations. |
Contributor
Author
|
For reference, here are my instructions for the Copilot cli: Result after 2 mins: 
I start pushing only a few of these branches as new PR, to avoid overloading our build systems. cc @fedejeanne |
Member
Reminds me on eclipse-jdt/eclipse.jdt.ui#2423. Which JUnit is used? Anything below 5.14 is known to have unstable test discovery. |
Contributor
Thank you for the hint! That's a good pointer. Update to JUnit 5.14 was done two days ago: eclipse-platform/eclipse.platform.releng.aggregator#3365 So maybe that's why the recent builds work fine. My runs are far older. |
Contributor
Author
|
Closing in favor of smaller updates as requested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.