-
Notifications
You must be signed in to change notification settings - Fork 229
Migrate org.eclipse.ui.workbench.texteditor.tests from JUnit4 to JUnit5 #3348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate org.eclipse.ui.workbench.texteditor.tests from JUnit4 to JUnit5 #3348
Conversation
vogella
commented
Oct 2, 2025
- Convert @RunWith(Suite.class) to @suite
- Convert @Suite.SuiteClasses to @SelectClasses
- Update imports from org.junit.runners to org.junit.platform.suite.api
- Add org.junit.jupiter.api and org.junit.platform.suite.api to Import-Package
Test Results 2 916 files +6 2 916 suites +6 2h 10m 43s ⏱️ - 2m 10s For more details on these failures, see this check. Results for commit edcefe4. ± Comparison against base commit ca934b3. This pull request removes 174 and adds 174 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
02a777d to
edcefe4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The failed Windows check seems like a hiccup:
Caused by: java.lang.RuntimeException: Error trying to download org.eclipse.e4.ui.services version 1.6.600.v20250917-1100 from https://download.eclipse.org/eclipse/updates/4.38-I-builds/I20250930-1800:
Download of osgi.bundle,org.eclipse.e4.ui.services,1.6.600.v20250917-1100 failed on repository https://download.eclipse.org/eclipse/updates/4.38-I-builds/I20250930-1800. Retrying. :
download from https://download.eclipse.org/eclipse/updates/4.38-I-builds/I20250930-1800/plugins/org.eclipse.e4.ui.services_1.6.600.v20250917-1100.jar failed
Caused by: java.io.EOFException: EOF reached while reading
at jdk.internal.net.http.Http2Connection$Http2TubeSubscriber.onComplete (Http2Connection.java:1885)
at jdk.internal.net.http.common.SSLTube$DelegateWrapper.onComplete (SSLTube.java:276)
at jdk.internal.net.http.common.SSLTube$SSLSubscriberWrapper.complete (SSLTube.java:440)
at jdk.internal.net.http.common.SSLTube$SSLSubscriberWrapper.onComplete (SSLTube.java:541)
at jdk.internal.net.http.common.SubscriberWrapper.checkCompletion (SubscriberWrapper.java:474)
at jdk.internal.net.http.common.SubscriberWrapper$DownstreamPusher.run1 (SubscriberWrapper.java:334)
at jdk.internal.net.http.common.SubscriberWrapper$DownstreamPusher.run (SubscriberWrapper.java:259)
at jdk.internal.net.http.common.SequentialScheduler$LockingRestartableTask.run (SequentialScheduler.java:182)
at jdk.internal.net.http.common.SequentialScheduler$CompleteRestartableTask.run (SequentialScheduler.java:149)
at jdk.internal.net.http.common.SequentialScheduler$SchedulableTask.run (SequentialScheduler.java:207)
at jdk.internal.net.http.common.SequentialScheduler.runOrSchedule (SequentialScheduler.java:280)
at jdk.internal.net.http.common.SequentialScheduler.runOrSchedule (SequentialScheduler.java:233)
at jdk.internal.net.http.common.SubscriberWrapper.outgoing (SubscriberWrapper.java:232)
at jdk.internal.net.http.common.SSLFlowDelegate$Reader.processData (SSLFlowDelegate.java:540)
at jdk.internal.net.http.common.SSLFlowDelegate$Reader$ReaderDownstreamPusher.run (SSLFlowDelegate.java:283)
at jdk.internal.net.http.common.SequentialScheduler$LockingRestartableTask.run (SequentialScheduler.java:182)
at jdk.internal.net.http.common.SequentialScheduler$CompleteRestartableTask.run (SequentialScheduler.java:149)
at jdk.internal.net.http.common.SequentialScheduler$SchedulableTask.run (SequentialScheduler.java:207)
at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1144)
at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:642)
at java.lang.Thread.run (Thread.java:1583)
Lets re-running these tests. |
|
Failing test is known to be flaky: #1517 |