Skip to content

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Oct 2, 2025

  • Convert @RunWith(Suite.class) to @suite
  • Convert @Suite.SuiteClasses to @SelectClasses
  • Update imports from org.junit.runners to org.junit.platform.suite.api
  • Add org.junit.jupiter.api and org.junit.platform.suite.api to Import-Package

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Test Results

 2 916 files  +6   2 916 suites  +6   2h 10m 43s ⏱️ - 2m 10s
 8 166 tests ±0   7 920 ✅ ±0  245 💤 ±0  1 ❌ ±0 
23 568 runs  ±0  22 785 ✅ ±0  782 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit edcefe4. ± Comparison against base commit ca934b3.

This pull request removes 174 and adds 174 tests. Note that renamed tests count towards both.
org.eclipse.ui.internal.findandreplace.FindReplaceLogicTest ‑ onlySelectAndReplacesIfFindSuccessfulOnCustomTarget
org.eclipse.ui.internal.findandreplace.FindReplaceLogicTest ‑ testCanReplaceAfterWrap
org.eclipse.ui.internal.findandreplace.FindReplaceLogicTest ‑ testDontSelectAndReplaceIfFindNotSuccessful
org.eclipse.ui.internal.findandreplace.FindReplaceLogicTest ‑ testIncrementBaseLocationWithRegEx
org.eclipse.ui.internal.findandreplace.FindReplaceLogicTest ‑ testIncrementalSearchBackwardNoUpdateIfAlreadyOnWord
org.eclipse.ui.internal.findandreplace.FindReplaceLogicTest ‑ testIncrementalSearchNoUpdateIfAlreadyOnWord
org.eclipse.ui.internal.findandreplace.FindReplaceLogicTest ‑ testPerformReplaceAllBackwards
org.eclipse.ui.internal.findandreplace.FindReplaceLogicTest ‑ testPerformReplaceAllForward
org.eclipse.ui.internal.findandreplace.FindReplaceLogicTest ‑ testPerformReplaceAllForwardRegEx
org.eclipse.ui.internal.findandreplace.FindReplaceLogicTest ‑ testPerformReplaceAllForwards
…
WorkbenchTextEditorTestSuite AbstractTextZoomHandlerTest ‑ textZoomIsNotSupportedForGenericObject
WorkbenchTextEditorTestSuite AbstractTextZoomHandlerTest ‑ textZoomIsNotSupportedForMultiEditorWithNonTextPage
WorkbenchTextEditorTestSuite AbstractTextZoomHandlerTest ‑ textZoomIsNotSupportedForMultiPageEditorPartWithNonTextPage
WorkbenchTextEditorTestSuite AbstractTextZoomHandlerTest ‑ textZoomIsNotSupportedForNonTextEditor
WorkbenchTextEditorTestSuite AbstractTextZoomHandlerTest ‑ textZoomIsSupportedForAbstractTextEditor
WorkbenchTextEditorTestSuite AbstractTextZoomHandlerTest ‑ textZoomIsSupportedForAdaptableToAbstractTextEditor
WorkbenchTextEditorTestSuite AbstractTextZoomHandlerTest ‑ textZoomIsSupportedForMultiEditorWithTextPage
WorkbenchTextEditorTestSuite AbstractTextZoomHandlerTest ‑ textZoomIsSupportedForMultiPageEditorPartWithAbstractTextEditorPage
WorkbenchTextEditorTestSuite ChangeRegionTest ‑ testCreation
WorkbenchTextEditorTestSuite ChangeRegionTest ‑ testHunkAfter
…

♻️ This comment has been updated with latest results.

- Convert @RunWith(Suite.class) to @suite
- Convert @Suite.SuiteClasses to @SelectClasses
- Update imports from org.junit.runners to org.junit.platform.suite.api
- Add org.junit.jupiter.api and org.junit.platform.suite.api to Import-Package
@akurtakov akurtakov force-pushed the junit5-ui-workbench-texteditor-tests branch from 02a777d to edcefe4 Compare October 2, 2025 11:27
Copy link
Member

@fedejeanne fedejeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The failed Windows check seems like a hiccup:

Caused by: java.lang.RuntimeException: Error trying to download org.eclipse.e4.ui.services version 1.6.600.v20250917-1100 from https://download.eclipse.org/eclipse/updates/4.38-I-builds/I20250930-1800:
Download of osgi.bundle,org.eclipse.e4.ui.services,1.6.600.v20250917-1100 failed on repository https://download.eclipse.org/eclipse/updates/4.38-I-builds/I20250930-1800. Retrying. :
   download from https://download.eclipse.org/eclipse/updates/4.38-I-builds/I20250930-1800/plugins/org.eclipse.e4.ui.services_1.6.600.v20250917-1100.jar failed
Caused by: java.io.EOFException: EOF reached while reading
    at jdk.internal.net.http.Http2Connection$Http2TubeSubscriber.onComplete (Http2Connection.java:1885)
    at jdk.internal.net.http.common.SSLTube$DelegateWrapper.onComplete (SSLTube.java:276)
    at jdk.internal.net.http.common.SSLTube$SSLSubscriberWrapper.complete (SSLTube.java:440)
    at jdk.internal.net.http.common.SSLTube$SSLSubscriberWrapper.onComplete (SSLTube.java:541)
    at jdk.internal.net.http.common.SubscriberWrapper.checkCompletion (SubscriberWrapper.java:474)
    at jdk.internal.net.http.common.SubscriberWrapper$DownstreamPusher.run1 (SubscriberWrapper.java:334)
    at jdk.internal.net.http.common.SubscriberWrapper$DownstreamPusher.run (SubscriberWrapper.java:259)
    at jdk.internal.net.http.common.SequentialScheduler$LockingRestartableTask.run (SequentialScheduler.java:182)
    at jdk.internal.net.http.common.SequentialScheduler$CompleteRestartableTask.run (SequentialScheduler.java:149)
    at jdk.internal.net.http.common.SequentialScheduler$SchedulableTask.run (SequentialScheduler.java:207)
    at jdk.internal.net.http.common.SequentialScheduler.runOrSchedule (SequentialScheduler.java:280)
    at jdk.internal.net.http.common.SequentialScheduler.runOrSchedule (SequentialScheduler.java:233)
    at jdk.internal.net.http.common.SubscriberWrapper.outgoing (SubscriberWrapper.java:232)
    at jdk.internal.net.http.common.SSLFlowDelegate$Reader.processData (SSLFlowDelegate.java:540)
    at jdk.internal.net.http.common.SSLFlowDelegate$Reader$ReaderDownstreamPusher.run (SSLFlowDelegate.java:283)
    at jdk.internal.net.http.common.SequentialScheduler$LockingRestartableTask.run (SequentialScheduler.java:182)
    at jdk.internal.net.http.common.SequentialScheduler$CompleteRestartableTask.run (SequentialScheduler.java:149)
    at jdk.internal.net.http.common.SequentialScheduler$SchedulableTask.run (SequentialScheduler.java:207)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1144)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:642)
    at java.lang.Thread.run (Thread.java:1583)

@vogella
Copy link
Contributor Author

vogella commented Oct 2, 2025

LGTM

The failed Windows check seems like a hiccup:

Lets re-running these tests.

@HeikoKlare
Copy link
Contributor

Failing test is known to be flaky: #1517

@HeikoKlare HeikoKlare merged commit 7847ded into eclipse-platform:master Oct 2, 2025
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants