Skip to content

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Oct 2, 2025

The test testSingleSelectionAndOneInitialSelectionWithInitialPattern was intermittently failing with ResourceException during project deletion in doTearDown() due to background jobs holding project locks.

Changes:

  • Add comprehensive UI event processing before/after cleanup
  • Wait for additional job families (FAMILY_MANUAL_REFRESH, FAMILY_AUTO_REFRESH)
  • Implement retry mechanism with proper NullProgressMonitor (5 retries, 1s delay)
  • Preserve existing exception chaining for debugging
  • Follow established Eclipse test patterns (ResourceHelper, ResourceActionTest)

This resolves intermittent test failures in CI/CD environments where decorator and resource refresh jobs interfere with project deletion.

Fixes: #294

@vogella
Copy link
Contributor Author

vogella commented Oct 2, 2025

The improvement was created by Copilot cli, lets see if it can fix our long outstanding flacky test. I assume the retry should at least make this problem appear less often.

@vogella
Copy link
Contributor Author

vogella commented Oct 2, 2025

Alternative implementation to #3372 which seems less inversive.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 45m 18s ⏱️ + 13m 26s
 8 215 tests ±0   7 966 ✅ ±0  249 💤 ±0  0 ❌ ±0 
23 565 runs  ±0  22 771 ✅ ±0  794 💤 ±0  0 ❌ ±0 

Results for commit 1c6578d. ± Comparison against base commit 8ce2da8.

♻️ This comment has been updated with latest results.

The test testSingleSelectionAndOneInitialSelectionWithInitialPattern
was intermittently failing with ResourceException during project
deletion in doTearDown() due to background jobs holding project locks.

Changes:
- Add comprehensive UI event processing before/after cleanup
- Wait for additional job families (FAMILY_MANUAL_REFRESH, FAMILY_AUTO_REFRESH)
- Implement retry mechanism with proper NullProgressMonitor (5 retries, 1s delay)
- Preserve existing exception chaining for debugging
- Follow established Eclipse test patterns (ResourceHelper, ResourceActionTest)

This resolves intermittent test failures in CI/CD environments where
decorator and resource refresh jobs interfere with project deletion.

Fixes: ResourceException: Problems encountered while deleting resources
@vogella vogella force-pushed the resource_initial_selection_test_fix_flackness branch from 5da56c9 to 1c6578d Compare October 5, 2025 11:30
@vogella vogella merged commit d77df82 into eclipse-platform:master Oct 8, 2025
25 of 26 checks passed
@vogella vogella deleted the resource_initial_selection_test_fix_flackness branch October 8, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some ResourceInitialSelectionTest tests fail intermittently

1 participant