Fix artifact lines in Forms UI Section headers #3381 #3383
Conversation
Test Results 3 018 files ±0 3 018 suites ±0 2h 36m 40s ⏱️ + 5m 26s For more details on these failures, see this check. Results for commit 4a8a0ff. ± Comparison against base commit 9a6b6ae. ♻️ This comment has been updated with latest results. |
|
LGTM, I will try Copilot review with this to test AI reviews. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a rendering bug in Eclipse Forms UI where section headers displayed artifact lines. The issue was caused by a previous change that mistakenly used width instead of height for filling the background rectangle.
- Corrects the fillRectangle operation to use the proper height parameter instead of width
|
Fixes also the dark theme issue under Linux: 
Thanks a lot @HeikoKlare |
Thank you for testing and reporting back! I hope that we have the test issues due to JUnit 6 fixed soon, as I would like to merge this with proper CI results (even though the change itself is quite trivial and will obviously not break anything). |
|
As nothing broke as it was broken it should not break anything now it is fixed so I think we should just merge it right away! |
Section headers show artifacts lines because a previous change accidentally changed the operation for filling the background to use a height of 1 instead of the actual height to be filled. Fixes eclipse-platform#3381
|
Thanks a lot for the quick solution! :) |
|
You're welcome. Thank you for reporting it! |
4 participants
Section headers show artifacts lines because a previous change accidentally changed the operation for filling the background to use a height of 1 instead of the actual height to be filled.
Fixes #3381
Before
After