Migrate JUnit 4 tests to JUnit 5 in org.eclipse.jface.tests #3412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogella
force-pushed
the
simple-jface-tests-junit5
branch
from
91966de to
00873e4
Compare
This commit fixes compilation and test failures introduced during the JUnit 4 to JUnit 5 migration in org.eclipse.jface.tests. Changes: - Added missing import for org.junit.jupiter.api.function package in MANIFEST.MF to resolve NoClassDefFoundError for Executable class used by assertThrows() in LabelProviderTest - Fixed assertEquals parameter order in Bug205700TreeViewerTest to match JUnit 5 signature: assertEquals(expected, actual, message) - Fixed assertEquals parameter order in WizardProgressMonitorTest to match JUnit 5 signature: assertEquals(expected, actual, message) The JUnit 5 assertEquals method has a different parameter order than JUnit 4. In JUnit 4 it was assertEquals(message, expected, actual) but in JUnit 5 it is assertEquals(expected, actual, message). All 1298 tests now pass successfully (0 failures, 0 errors, 3 skipped). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.