Skip to content

Migrate org.eclipse.jface.tests.notifications from JUnit 4 to JUnit 5 #3415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

Migrate org.eclipse.jface.tests.notifications from JUnit 4 to JUnit 5 #3415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/org.eclipse.jface.tests.notifications/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ Bundle-Name: Jface notifications tests
Bundle-SymbolicName: org.eclipse.jface.tests.notifications
Bundle-Vendor: Eclipse.org
Bundle-Version: 0.2.0.qualifier
Import-Package: org.junit.jupiter.api;version="[5.14.0,6.0.0)",
Import-Package: org.hamcrest,
org.junit.jupiter.api;version="[5.14.0,6.0.0)",
org.junit.platform.suite.api;version="[1.14.0,2.0.0)"
Automatic-Module-Name: org.eclipse.jface.notifications.tests
Bundle-RequiredExecutionEnvironment: JavaSE-17
Require-Bundle: org.junit,
org.eclipse.jface.notifications;bundle-version="0.4.0",
Require-Bundle: org.eclipse.jface.notifications;bundle-version="0.4.0",
org.eclipse.swt,
org.eclipse.jface,
org.eclipse.ui.forms,
Expand Down
26 changes: 13 additions & 13 deletions ....tests.notifications/src/org/eclipse/jface/tests/notifications/NotificationPopupTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,25 +39,25 @@
import org.hamcrest.BaseMatcher;
import org.hamcrest.Description;
import org.hamcrest.Matcher;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;

@SuppressWarnings("restriction")
public class NotificationPopupTest {
class NotificationPopupTest {

private Display display;
private Builder builder;
private Shell shell;

@Before
public void setUp() {
@BeforeEach
void setUp() {
this.display = Display.getDefault();
this.builder = NotificationPopup.forDisplay(this.display);
}

@After
public void tearDown() {
@AfterEach
void tearDown() {
if (shell != null) {
shell.close();
shell.dispose();
Expand All @@ -70,7 +70,7 @@ public void tearDown() {
}

@Test
public void createsWithTextAndTitle() {
void createsWithTextAndTitle() {
NotificationPopup notication = this.builder.text("This is a test").title("Hello World", false).delay(1).build();
notication.open();
List<Control> controls = getNotificationPopupControls(notication);
Expand All @@ -81,7 +81,7 @@ public void createsWithTextAndTitle() {
}

@Test
public void createsWithCloseButton() {
void createsWithCloseButton() {
NotificationPopup notication = this.builder.text("This is a test").title("Hello World", true).delay(1).build();
notication.open();
List<Control> controls = getNotificationPopupControls(notication);
Expand All @@ -91,7 +91,7 @@ public void createsWithCloseButton() {
}

@Test
public void createsWithTextContent() {
void createsWithTextContent() {
Text[] text = new Text[1];
NotificationPopup notication = this.builder.title("Hello World", false).content(parent -> {
text[0] = new Text(parent, SWT.NONE);
Expand All @@ -107,7 +107,7 @@ public void createsWithTextContent() {
}

@Test
public void createsWithTitleContent() {
void createsWithTitleContent() {
Text[] text = new Text[1];
NotificationPopup notication = this.builder.title(parent -> {
text[0] = new Text(parent, SWT.NONE);
Expand All @@ -122,7 +122,7 @@ public void createsWithTitleContent() {
}

@Test
public void createsForShell() {
void createsForShell() {
shell = WidgetFactory.shell(SWT.NONE).create(display);
this.builder = NotificationPopup.forShell(shell);

Expand Down
Loading