Skip to content

Clean Code for bundles/org.eclipse.e4.ui.css.swt #3435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

Clean Code for bundles/org.eclipse.e4.ui.css.swt #3435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/CTabFolderElement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
public class CTabFolderElement extends CompositeElement implements ChildVisibilityAwareElement {
private static final String BACKGROUND_SET_BY_TAB_RENDERER = "bgSetByTabRenderer"; //$NON-NLS-1$

private SelectionListener selectionListener = new SelectionAdapter() {
private final SelectionListener selectionListener = new SelectionAdapter() {
@Override
public void widgetSelected(SelectionEvent e) {
applyStyles(getWidget(), true);
Expand Down
4 changes: 2 additions & 2 deletions bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/ControlElement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public class ControlElement extends WidgetElement {

protected boolean hasMouseHover = false;

private FocusListener focusListener = new FocusAdapter() {
private final FocusListener focusListener = new FocusAdapter() {
@Override
public void focusGained(FocusEvent e) {
ControlElement.this.hasFocus = true;
Expand All @@ -56,7 +56,7 @@ public void focusLost(FocusEvent e) {
};

// Create SWT MouseTrack listener
private MouseTrackListener mouseHoverListener = new MouseTrackAdapter() {
private final MouseTrackListener mouseHoverListener = new MouseTrackAdapter() {
@Override
public void mouseEnter(MouseEvent e) {
// mouse hover, apply styles
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/ShellElement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public class ShellElement extends CompositeElement {
protected boolean isActive;

// Create SWT Shell Listener
private ShellListener shellListener = new ShellListener() {
private final ShellListener shellListener = new ShellListener() {

@Override
public void shellActivated(ShellEvent e) {
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/ToolItemElement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public class ToolItemElement extends ItemElement {

boolean dynamicEnabled = Boolean.getBoolean("org.eclipse.e4.ui.css.dynamic");

private SelectionListener selectionListener = new SelectionAdapter() {
private final SelectionListener selectionListener = new SelectionAdapter() {
@Override
public void widgetSelected(SelectionEvent e) {
ToolItem toolItem = getToolItem();
Expand Down
2 changes: 1 addition & 1 deletion ...4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/properties/css2/CSSPropertyFontSWTHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ private class FontSelectionListener implements Listener {
* retrieved from the style sheet. This list must be updated if
* AbstractCSSPropertyFontHandler's listing changes.
*/
private String[] fontAttributes = { "font", "font-family", "font-size",
private final String[] fontAttributes = { "font", "font-family", "font-size",
"font-adjust", "font-stretch", "font-style", "font-variant",
"font-weight" };

Expand Down
2 changes: 1 addition & 1 deletion ...eclipse/e4/ui/css/swt/properties/definition/CSSPropertyThemeElementDefinitionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public class CSSPropertyThemeElementDefinitionHandler implements ICSSPropertyHan

private static final String EDITABLE_PROP = "editable";

private Map<Long, ResourceBundle> bundleToResourceBundles = new WeakHashMap<>();
private final Map<Long, ResourceBundle> bundleToResourceBundles = new WeakHashMap<>();

@Override
public boolean applyCSSProperty(Object element, String property,
Expand Down
Loading