Skip to content

disable redrawing when setting visible region to prevent flickering #3457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

disable redrawing when setting visible region to prevent flickering #3457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...ipse.jface.text/projection/org/eclipse/jface/text/source/projection/ProjectionViewer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,6 +767,8 @@ public void setVisibleRegion(int start, int length) {
if (document == null) {
return;
}
int topIndex= redraws() ? getTopIndex() : -1;
setRedraw(false);
try {
// If the visible region changes, make sure collapsed regions outside of the old visible regions are expanded
// and collapse everything outside the new visible region
Expand All @@ -782,6 +784,8 @@ public void setVisibleRegion(int start, int length) {
} catch (BadLocationException e) {
ILog log= ILog.of(getClass());
log.log(new Status(IStatus.WARNING, getClass(), IStatus.OK, null, e));
} finally {
setRedraw(true, topIndex);
}
}

Expand Down
Loading