Skip to content

Clean Code for bundles/org.eclipse.core.databinding.observable #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 1 commit into from
Nov 3, 2025
Merged

Clean Code for bundles/org.eclipse.core.databinding.observable #3478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...abinding.observable/src/org/eclipse/core/databinding/observable/map/BidirectionalMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ public class BidirectionalMap<K, V> extends ObservableMap<K, V> {
* @param wrappedMap backing store for the map data, used to implement all map
* operations
*/
@Deprecated
public BidirectionalMap(IObservableMap<K, V> wrappedMap) {
super(wrappedMap.getRealm(), wrappedMap);
wrappedMap.addMapChangeListener(mapListener);
Expand Down
4 changes: 4 additions & 0 deletions ...ore.databinding.observable/src/org/eclipse/core/databinding/observable/set/MappedSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ public void handleSetChange(SetChangeEvent event) {
* @param input input set with keys from the map
* @param map the map to map
*/
@Deprecated
public MappedSet(IObservableSet input, IObservableMap map) {
super(input.getRealm(), Collections.EMPTY_SET, Object.class);
setWrappedSet(valueCounts.keySet());
Expand All @@ -126,6 +127,7 @@ public MappedSet(IObservableSet input, IObservableMap map) {
* @param mapValue map value to add
* @return true if the given mapValue was an addition
*/
@Deprecated
protected boolean handleAddition(Object mapValue) {
Integer count = (Integer) valueCounts.get(mapValue);
if (count == null) {
Expand All @@ -140,6 +142,7 @@ protected boolean handleAddition(Object mapValue) {
* @param mapValue map value to remove
* @return true if the given mapValue has been removed
*/
@Deprecated
protected boolean handleRemoval(Object mapValue) {
Integer count = (Integer) valueCounts.get(mapValue);
if (count.intValue() <= 1) {
Expand All @@ -150,6 +153,7 @@ protected boolean handleRemoval(Object mapValue) {
return false;
}

@Deprecated
@Override
public synchronized void dispose() {
wrappedMap.removeMapChangeListener(mapChangeListener);
Expand Down
Loading