Clean Code for bundles/org.eclipse.jface

bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/AnimatorFactory.java

@@ -37,6 +37,7 @@ public class AnimatorFactory {
 	 * @return the ControlAnimator.
 	 * @since 3.2
 	 */
+	@Deprecated
 	public ControlAnimator createAnimator(Control control) {
 		return new ControlAnimator(control);
 	}

bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/ControlAnimator.java

@@ -31,6 +31,7 @@
 @Deprecated(forRemoval = true, since = "2025-03")
 public class ControlAnimator {
 	/** the control that will be displayed or hidden */
+	@Deprecated
 	protected Control control;
 
 	/**
@@ -39,6 +40,7 @@ public class ControlAnimator {
 	 *
 	 * @param control the control that will be displayed or hidden.
 	 */
+	@Deprecated
 	public ControlAnimator(Control control) {
 		this.control = control;
 	}
@@ -51,6 +53,7 @@ public ControlAnimator(Control control) {
 	 * @param visible <code>true</code> if the control should be shown,
 	 * 		  and <code>false</code> otherwise.
 	 */
+	@Deprecated
 	public void setVisible(boolean visible){
 		// Using the SWT visible flag to determine if the control has
 		// already been displayed or hidden. Return if already displayed

bundles/org.eclipse.jface/src/org/eclipse/jface/fieldassist/DecoratedField.java

@@ -154,6 +154,7 @@
 	/**
 	 * The hover used to show a decoration image's description.
 	 */
+	@Deprecated
 	class Hover {
 		private static final String EMPTY = ""; //$NON-NLS-1$
 
@@ -180,28 +181,28 @@
 		/**
 		 * This info hover's shell.
 		 */
 		Shell hoverShell;
 
 		/**
 		 * The info hover text.
 		 */
 		String text = EMPTY;
 
 		/**
 		 * The region used to manage the shell shape
 		 */
 		Region region;
 
 		/**
 		 * Boolean indicating whether the last computed polygon location had an
 		 * arrow on left. (true if left, false if right).
 		 */
 		boolean arrowOnLeft = true;
 
 		/*
 		 * Create a hover parented by the specified shell.
 		 */
 		Hover(Shell parent) {
 			final Display display = parent.getDisplay();
 			hoverShell = new Shell(parent, SWT.NO_TRIM | SWT.ON_TOP
 					| SWT.NO_FOCUS | SWT.TOOL);
@@ -228,7 +229,7 @@
 		 * border is true, compute the polygon inset by 1-pixel border. Consult
 		 * the arrowOnLeft flag to determine which side the arrow is on.
 		 */
 		int[] getPolygon(boolean border) {
 			Point e = getExtent();
 			int b = border ? 1 : 0;
 			if (arrowOnLeft) {
@@ -245,7 +246,7 @@
 		 * Dispose the hover, it is no longer needed. Dispose any resources
 		 * allocated by the hover.
 		 */
 		void dispose() {
 			if (!hoverShell.isDisposed()) {
 				hoverShell.dispose();
 			}
@@ -257,7 +258,7 @@
 		/*
 		 * Set the visibility of the hover.
 		 */
 		void setVisible(boolean visible) {
 			if (visible) {
 				if (!hoverShell.isVisible()) {
 					hoverShell.setVisible(true);
@@ -272,7 +273,7 @@
 		 * and location of the hover to hover near the specified control,
 		 * pointing the arrow toward the target control.
 		 */
 		void setText(String t, Control hoverNear, Control targetControl) {
 			if (t == null) {
 				t = EMPTY;
 			}
@@ -303,14 +304,14 @@
 		/*
 		 * Return whether or not the hover (shell) is visible.
 		 */
 		boolean isVisible() {
 			return hoverShell.isVisible();
 		}
 
 		/*
 		 * Compute the extent of the hover for the current text.
 		 */
 		Point getExtent() {
 			GC gc = new GC(hoverShell);
 			Point e = gc.textExtent(text);
 			gc.dispose();
@@ -322,7 +323,7 @@
 		/*
 		 * Compute a new shape for the hover shell.
 		 */
 		void setNewShape() {
 			Region oldRegion = region;
 			region = new Region();
 			region.add(getPolygon(false));
@@ -349,6 +350,7 @@
 	 *
 	 * @see IControlCreator
 	 */
+	@Deprecated
 	public DecoratedField(Composite parent, int style,
 			IControlCreator controlCreator) {
 		this.form = createForm(parent);
@@ -394,6 +396,7 @@
 	 *            when the associated control has focus, <code>false</code> if
 	 *            it should always be shown.
 	 */
+	@Deprecated
 	public void addFieldDecoration(FieldDecoration decoration, int position,
 			boolean showOnFocus) {
 		final Label label;
@@ -534,6 +537,7 @@
 	 * @return the Control decorated by the receiver, or <code>null</code> if
 	 *         none has been created yet.
 	 */
+	@Deprecated
 	public Control getControl() {
 		return control;
 	}
@@ -546,6 +550,7 @@
 	 *         layout. This is typically not the control itself, since
 	 *         additional controls are used to represent the decorations.
 	 */
+	@Deprecated
 	public Control getLayoutControl() {
 		return form;
 	}
@@ -671,6 +676,7 @@
 	 *            the text to be shown in the info hover, or <code>null</code>
 	 *            if no text should be shown.
 	 */
+	@Deprecated
 	public void showHoverText(String text) {
 		showHoverText(text, control);
 	}
@@ -686,6 +692,7 @@
 	 * <p>
 	 * This message has no effect if there is no current hover.
 	 */
+	@Deprecated
 	public void hideHover() {
 		if (hover != null) {
 			hover.setVisible(false);
@@ -724,6 +731,7 @@
 	 * @param decoration
 	 *            the decoration to be shown.
 	 */
+	@Deprecated
 	public void showDecoration(FieldDecoration decoration) {
 		FieldDecorationData data = getDecorationData(decoration);
 		if (data == null) {
@@ -746,6 +754,7 @@
 	 * @param decoration
 	 *            the decoration to be hidden.
 	 */
+	@Deprecated
 	public void hideDecoration(FieldDecoration decoration) {
 		FieldDecorationData data = getDecorationData(decoration);
 		if (data == null) {
@@ -767,6 +776,7 @@
 	 * @param decoration
 	 *            the decoration to be hidden.
 	 */
+	@Deprecated
 	public void updateDecoration(FieldDecoration decoration) {
 		FieldDecorationData data = getDecorationData(decoration);
 		if (data == null) {
@@ -852,6 +862,7 @@
 	 *
 	 * @see FieldDecorationRegistry#getMaximumDecorationWidth()
 	 */
+	@Deprecated
 	public void setUseMaximumDecorationWidth(boolean useMaximumWidth) {
 		useMaxDecorationWidth = useMaximumWidth;
 	}

bundles/org.eclipse.jface/src/org/eclipse/jface/fieldassist/FieldAssistColors.java

@@ -77,6 +77,7 @@ public class FieldAssistColors {
 	 * @return the RGB value indicating a background color appropriate for
 	 *         indicating an error in the control.
 	 */
+	@Deprecated
 	public static RGB computeErrorFieldBackgroundRGB(Control control) {
 		/*
 		 * Use a 10% alpha of the error color applied on top of the widget
@@ -109,6 +110,7 @@ public static RGB computeErrorFieldBackgroundRGB(Control control) {
 	 *            the control on which the background color will be used.
 	 * @return the color used to indicate that a field is required.
 	 */
+	@Deprecated
 	public static Color getRequiredFieldBackgroundColor(Control control) {
 		final Display display = control.getDisplay();
 

bundles/org.eclipse.jface/src/org/eclipse/jface/fieldassist/IControlCreator.java

@@ -38,5 +38,6 @@ public interface IControlCreator {
 	 *
 	 * @return the Control that was created.
 	 */
+	@Deprecated
 	public Control createControl(Composite parent, int style);
 }

bundles/org.eclipse.jface/src/org/eclipse/jface/fieldassist/TextControlCreator.java

@@ -28,6 +28,7 @@
 @Deprecated
 public class TextControlCreator implements IControlCreator {
 
+	@Deprecated
 	@Override
 	public Control createControl(Composite parent, int style) {
 		return new Text(parent, style);

bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/ViewerSorter.java

@@ -52,6 +52,7 @@ public class ViewerSorter extends ViewerComparator {
 	 * Creates a new viewer sorter, which uses the default collator
 	 * to sort strings.
 	 */
+	@Deprecated
 	public ViewerSorter() {
 		this(Collator.getInstance());
 	}
@@ -62,6 +63,7 @@ public ViewerSorter() {
 	 *
 	 * @param collator the collator to use to sort strings
 	 */
+	@Deprecated
 	public ViewerSorter(Collator collator) {
 		super(collator);
 		this.collator = collator;