Skip to content

Clean Code for bundles/org.eclipse.ui.ide #3486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

Clean Code for bundles/org.eclipse.ui.ide #3486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/CreateFileAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,13 @@ public class CreateFileAction extends SelectionListenerAction {
/**
* The id of this action.
*/
@Deprecated
public static final String ID = PlatformUI.PLUGIN_ID + ".CreateFileAction";//$NON-NLS-1$

/**
* The shell in which to show any dialogs.
*/
@Deprecated
protected IShellProvider shellProvider;

/**
Expand Down Expand Up @@ -96,6 +98,7 @@ private void initAction(){
* <code>IAction</code> method opens a <code>BasicNewFileResourceWizard</code>
* in a wizard dialog under the shell passed to the constructor.
*/
@Deprecated
@Override
public void run() {
BasicNewFileResourceWizard wizard = new BasicNewFileResourceWizard();
Expand All @@ -115,6 +118,7 @@ public void run() {
* <code>SelectionListenerAction</code> method enables the action only
* if the selection contains folders and open projects.
*/
@Deprecated
@Override
protected boolean updateSelection(IStructuredSelection s) {
if (!super.updateSelection(s)) {
Expand Down
4 changes: 4 additions & 0 deletions bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/CreateFolderAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,14 @@ public class CreateFolderAction extends SelectionListenerAction {
/**
* The id of this action.
*/
@Deprecated
public static final String ID = PlatformUI.PLUGIN_ID
+ ".CreateFolderAction";//$NON-NLS-1$

/**
* The shell in which to show any dialogs.
*/
@Deprecated
protected IShellProvider shellProvider;

/**
Expand Down Expand Up @@ -100,6 +102,7 @@ private void initAction(){
* <code>IAction</code> method opens a <code>BasicNewFolderResourceWizard</code>
* in a wizard dialog under the shell passed to the constructor.
*/
@Deprecated
@Override
public void run() {
BasicNewFolderResourceWizard wizard = new BasicNewFolderResourceWizard();
Expand All @@ -120,6 +123,7 @@ public void run() {
* <code>SelectionListenerAction</code> method enables the action only
* if the selection contains folders and open projects.
*/
@Deprecated
@Override
protected boolean updateSelection(IStructuredSelection s) {
if (!super.updateSelection(s)) {
Expand Down
5 changes: 5 additions & 0 deletions bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/QuickStartAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ public class QuickStartAction extends Action implements
* page.
* </p>
*/
@Deprecated
public QuickStartAction() {
this(PlatformUI.getWorkbench().getActiveWorkbenchWindow());
}
Expand All @@ -74,6 +75,7 @@ public QuickStartAction() {
* Creates an instance of this action, for use in the given window.
* @param window the window
*/
@Deprecated
public QuickStartAction(IWorkbenchWindow window) {
super(IDEWorkbenchMessages.QuickStart_text);
if (window == null) {
Expand All @@ -90,6 +92,7 @@ public QuickStartAction(IWorkbenchWindow window) {
* The user has invoked this action. Prompts for a feature with a welcome page,
* then opens the corresponding welcome page.
*/
@Deprecated
@Override
public void run() {
if (workbenchWindow == null) {
Expand Down Expand Up @@ -155,6 +158,7 @@ private AboutInfo promptForFeature() {
* @return <code>true</code> if successful, <code>false</code> otherwise
* @throws WorkbenchException if operation failed
*/
@Deprecated
public boolean openWelcomePage(String featureId) throws WorkbenchException {
AboutInfo feature = findFeature(featureId);
if (feature == null || feature.getWelcomePageURL() == null) {
Expand Down Expand Up @@ -252,6 +256,7 @@ private boolean openWelcomePage(AboutInfo feature) {
return true;
}

@Deprecated
@Override
public void dispose() {
if (workbenchWindow == null) {
Expand Down
7 changes: 7 additions & 0 deletions bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/ScrubLocalAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,15 @@ public class ScrubLocalAction extends WorkspaceAction {
/**
* The id of this action.
*/
@Deprecated
public static final String ID = "org.eclipse.ui.ScrubLocalAction";//$NON-NLS-1$

/**
* Creates a new action.
*
* @param shell the shell for any dialogs
*/
@Deprecated
public ScrubLocalAction(Shell shell) {
super(shell, IDEWorkbenchMessages.ScrubLocalAction_text);
setToolTipText(IDEWorkbenchMessages.ScrubLocalAction_toolTip);
Expand All @@ -53,21 +55,25 @@ public ScrubLocalAction(Shell shell) {
IIDEHelpContextIds.SCRUB_LOCAL_ACTION);
}

@Deprecated
@Override
protected String getOperationMessage() {
return IDEWorkbenchMessages.ScrubLocalAction_progress;
}

@Deprecated
@Override
protected String getProblemsMessage() {
return IDEWorkbenchMessages.ScrubLocalAction_problemsMessage;
}

@Deprecated
@Override
protected String getProblemsTitle() {
return IDEWorkbenchMessages.ScrubLocalAction_problemsTitle;
}

@Deprecated
@Override
protected void invokeOperation(IResource resource, IProgressMonitor monitor)
throws CoreException {
Expand All @@ -79,6 +85,7 @@ protected void invokeOperation(IResource resource, IProgressMonitor monitor)
* <code>SelectionListenerAction</code> method ensures that this action is
* disabled if any of the selections are not resources.
*/
@Deprecated
@Override
protected boolean updateSelection(IStructuredSelection s) {
return super.updateSelection(s)
Expand Down
8 changes: 8 additions & 0 deletions bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/undo/ResourceDescription.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public abstract class ResourceDescription {
* @param resource the resource from which a description should be created
* @return the resource description
*/
@Deprecated
public static ResourceDescription fromResource(IResource resource) {
IResourceSnapshot<IResource> delegate = ResourceSnapshotFactory.fromResource(resource);
return new ResourceDescription() {
Expand Down Expand Up @@ -91,13 +92,15 @@ public boolean verifyExistence(boolean checkMembers) {
* @return the resource handle that can be used to create a resource from this
* description
*/
@Deprecated
public abstract IResource createResourceHandle();

/**
* Get the name of this resource.
*
* @return the name of the Resource
*/
@Deprecated
public abstract String getName();

/**
Expand All @@ -107,6 +110,7 @@ public boolean verifyExistence(boolean checkMembers) {
* @return a resource that has the attributes of this resource description
* @throws CoreException if creation failed
*/
@Deprecated
public abstract IResource createResource(IProgressMonitor monitor) throws CoreException;

/**
Expand All @@ -117,6 +121,7 @@ public boolean verifyExistence(boolean checkMembers) {
* @param monitor the progress monitor to be used when creating the resource
* @throws CoreException if creation failed
*/
@Deprecated
public abstract void createExistentResourceFromHandle(IResource resource, IProgressMonitor monitor)
throws CoreException;

Expand All @@ -127,6 +132,7 @@ public abstract void createExistentResourceFromHandle(IResource resource, IProgr
* @return <code>true</code> if the resource can be created, and
* <code>false</code> if it does not have enough information
*/
@Deprecated
public abstract boolean isValid();

/**
Expand All @@ -137,6 +143,7 @@ public abstract void createExistentResourceFromHandle(IResource resource, IProgr
* @param monitor the progress monitor to be used
* @throws CoreException in case of error
*/
@Deprecated
public abstract void recordStateFromHistory(IResource resource, IProgressMonitor monitor) throws CoreException;

/**
Expand All @@ -151,6 +158,7 @@ public abstract void createExistentResourceFromHandle(IResource resource, IProgr
* @return a boolean indicating whether this description represents an existent
* resource.
*/
@Deprecated
public abstract boolean verifyExistence(boolean checkMembers);
}

2 changes: 2 additions & 0 deletions bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/framelist/FrameListMessages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ private FrameListMessages() {
* @param args the message arguments
* @return the string
*/
@Deprecated
public static String format(String key, Object[] args) {
return key;
}
Expand All @@ -46,6 +47,7 @@ public static String format(String key, Object[] args) {
* @param key the resource name
* @return the string
*/
@Deprecated
public static String getString(String key) {
return key;
}
Expand Down
2 changes: 2 additions & 0 deletions bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/properties/IDEPropertiesMessages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ private IDEPropertiesMessages() {
* @param args the message arguments
* @return the string
*/
@Deprecated
public static String format(String key, Object[] args) {
return key;
}
Expand All @@ -46,6 +47,7 @@ public static String format(String key, Object[] args) {
* @param key the resource name
* @return the string
*/
@Deprecated
public static String getString(String key) {
return key;
}
Expand Down
Loading