Add support for nested problems display for hierarchical projects #3488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if one select in Project Explorer to display projects not only flat but hierarchical and choose the "Problems on selected Project" filtering (but other filters are affected as well) the following happens: - We have Project P with nested projects X, Y, Z - Y has a compile problem and X has warnings - Now P shows a red icon because it has problems of type error inherited - I select P but Problems View remains empty - One has to first expand P, then locate Y and select it - To see the warning I have to locate X and select it so there is an inconsistency (P shows problems icon but problems view is empty) and an inconvenience (I need to select individual childs to see all problems/warnings). This now enhances the ExtendedMarkersView by a method isProjectNestingActive (returns false by default) to allow view extensions to decide if they want to enable discovery of nested projects or not. The ProblemsView is further enhanced to detect the situation and returns true for this particular case.
Contributor
Test Results 3 018 files ±0 3 018 suites ±0 2h 23m 8s ⏱️ +4s For more details on these failures, see this check. Results for commit a27d923. ± Comparison against base commit 3a441d9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if one select in Project Explorer to display projects not only flat but hierarchical and choose the "Problems on selected Project" filtering (but other filters are affected as well) the following happens:
Pwith nested projectsX,Y,ZYhas a compile problem andXhas warningsPshows a red icon because it has problems of type error inheritedPbut Problems View remains emptyP, then locateYand select itXand select itso there is an inconsistency (
Pshows problems icon but problems view is empty) and an inconvenience (I need to select individual childs to see all problems/warnings on a parent of nested projects).This now enhances the
ExtendedMarkersViewby a methodisProjectNestingActive(returns false by default) to allow view extensions to decide if they want to enable discovery of nested projects or not. TheProblemsViewis further enhanced to detect the situation and returns true for this particular case.See also https://bugs.eclipse.org/bugs/show_bug.cgi?id=573535
Before
After