Skip to content

Fix flaky test FileSearchTests.testBinaryContentTypeWithDescriber #3497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogella merged 1 commit into from
Nov 6, 2025
Merged

Fix flaky test FileSearchTests.testBinaryContentTypeWithDescriber #3497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/org.eclipse.search.tests/src/org/eclipse/search/tests/filesearch/FileSearchTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,13 +601,16 @@ private void testBinaryContentTypeWithDescriber(TestResultCollector collector) t
.forEach(extension -> registry.removeExtension(extension, masterToken));
}) {

IFolder folder= ResourceHelper.createFolder(fProject.getFolder("folder1"));
// Use unique folder name to avoid conflicts with other tests running in parallel
String uniqueFolderName= "binaryContentTypeTest-" + java.util.UUID.randomUUID().toString();
IFolder folder= ResourceHelper.createFolder(fProject.getFolder(uniqueFolderName));
IFile textfile= ResourceHelper.createFile(folder, "textfile", "text hello");
IFile binaryfile= ResourceHelper.createFile(folder, "binaryfile", "binary hello");

Pattern searchPattern= PatternConstructor.createPattern("hello", true, false);

FileTextSearchScope scope= FileTextSearchScope.newSearchScope(new IResource[] { fProject }, (String[]) null, false);
// Search only in the unique folder to avoid interference from other tests
FileTextSearchScope scope= FileTextSearchScope.newSearchScope(new IResource[] { folder }, (String[]) null, false);
TextSearchEngine.create().search(scope, collector, searchPattern, null);

TestResult[] results= collector.getResults();
Expand Down
Loading