Remove unnecessary quotes from link text #3511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ComparePreferencePage.colorAndFontLink were originally added for emphasis in UI. Since the text already appears as a blue clickable link, the additional quotes seems unnecessary. Removing the quotes makes the message cleaner and consistent. This also aligns with other similar preference links across the UI where such quotes are not used.
elsazac
force-pushed
the
renamelinksUI
branch
from
8a4ea8b to
0cbd276
Compare
Contributor
Member
|
This UI cleanup. |
Contributor
|
Thanks @elsazac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The single quotes around the placeholder text in the preference page were likely added following older UI conventions. Quotes often differentiate literal text or placeholders from the rest of the message. Since the text already appears as a blue clickable link, the additional quotes feels unnecessary. Removing them keeps the link still clickable while making the message cleaner and consistent with other preference links across the UI, where such quotes are not used.
eg : most of the links in preference page appear this way ->
Similarly this brings a constant behaviour across UI,
Before:
After:
