Skip to content

Conversation

@HeikoKlare
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2025

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 3m 27s ⏱️ - 4m 8s
 8 234 tests ±0   7 984 ✅  - 1  249 💤 ±0  1 ❌ +1 
23 622 runs  ±0  22 827 ✅  - 1  794 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit ce920fe. ± Comparison against base commit f655706.

@HeikoKlare
Copy link
Contributor Author

Just removes unused NLS entry. Failing test is unrelated and documented as flaky: #370

@HeikoKlare HeikoKlare merged commit 6c82a83 into eclipse-platform:master Nov 9, 2025
16 of 18 checks passed
@HeikoKlare HeikoKlare deleted the unused-hidpi-nls branch November 9, 2025 18:14
@vogella
Copy link
Contributor

vogella commented Nov 9, 2025

Just removes unused NLS entry. Failing test is unrelated and documented as flaky: #370

I let Claude Code have a look at #370. In case you have the time, please apply the "flacky test" to all flacky test known. With clause I have an excellent tool at hand to work on these and IMHO stable tests are very important for an efficient contribution process.

@vogella
Copy link
Contributor

vogella commented Nov 9, 2025

Or just assign these issues to me @HeikoKlare ...

@vogella
Copy link
Contributor

vogella commented Nov 9, 2025

Just removes unused NLS entry. Failing test is unrelated and documented as flaky: #370

I let Claude Code have a look at #370. In case you have the time, please apply the "flacky test" to all flacky test known. With clause I have an excellent tool at hand to work on these and IMHO stable tests are very important for an efficient contribution process.

#3523

@vogella
Copy link
Contributor

vogella commented Nov 9, 2025

Claude found and classified the following issues for flacky tests:

  1. [Tests] Random failing ProgressContantsTest.testKeepOneProperty #370 - Random failing ProgressContantsTest.testKeepOneProperty (your current work)
  2. PartRenderingEngineTests test fails randomly #751 - PartRenderingEngineTests test fails randomly
  3. Random failing LargeFileTest #2622 - Random failing LargeFileTest (macOS, good first issue)
  4. Random failing FileBuffersForFilesInLinkedFolders #2528 - Random failing FileBuffersForFilesInLinkedFolders
  5. Random failing org.eclipse.jface.text.tests.reconciler.FastAbstractReconcilerTest#testReplacingDocumentWhenClean() #2708 - Random failing FastAbstractReconcilerTest#testReplacingDocumentWhenClean()
  6. Random failing AnnotationManagerTest.testRemoveQuery #867 - Random failing AnnotationManagerTest.testRemoveQuery (macOS)
  7. Random BrokenBarrierException in EventLoopMonitorThreadTests #2702 - Random BrokenBarrierException in EventLoopMonitorThreadTests
  8. DynamicTest.testDynamicRegistry fails randomly #2458 - DynamicTest.testDynamicRegistry fails randomly
  9. Random failing PlatformUITest#testCreateAndRunWorkbench() #1517 - Random failing PlatformUITest#testCreateAndRunWorkbench()
  10. Random failing of HoverTest.testEnabledWhenHover() #926 - Random failing HoverTest.testEnabledWhenHover() (help wanted)
  11. [Test] org.eclipse.text.quicksearch.tests.QuickAccessComputerTest.testQuickAccessComputer fails randomly #3042 - QuickAccessComputerTest.testQuickAccessComputer fails randomly (macOS)
  12. Random Failing testProblemHover in genericeditor.tests.HoverTest #1808 - Random Failing testProblemHover in genericeditor.tests.HoverTest
  13. Random failing org.eclipse.ui.tests.navigator.SorterTest#testComparatorAsSorter #1139 - Random failing SorterTest#testComparatorAsSorter
  14. org.eclipse.jface.text.tests.reconciler.AbstractReconcilerTest.testDirtyingWhenClean fails randomly #2460 - AbstractReconcilerTest.testDirtyingWhenClean fails randomly
  15. Silently erroring VirtualLazyTreeViewerTest and VirtualTableViewerTest #1583 - Silently erroring VirtualLazyTreeViewerTest and VirtualTableViewerTest

@BeckerWdf
Copy link
Member

Claude found and classified the following issues for flacky tests:

But how is this related to unused NLS entries?

@vogella
Copy link
Contributor

vogella commented Nov 10, 2025

Claude found and classified the following issues for flacky tests:

But how is this related to unused NLS entries?

This PR was merged with failing tests so I used the opportunity to gather what reports we have for failing tests. I think this is described in #3522 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants