Skip to content

Fix flaky HoverTest.testEnabledWhenHover() race condition #3524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2025
Merged

Fix flaky HoverTest.testEnabledWhenHover() race condition #3524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .../org.eclipse.ui.genericeditor.tests/src/org/eclipse/ui/genericeditor/tests/HoverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import org.eclipse.swt.custom.StyledText;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.Display;
import org.eclipse.swt.widgets.Event;
import org.eclipse.swt.widgets.Label;
import org.eclipse.swt.widgets.Link;
Expand Down Expand Up @@ -80,7 +81,13 @@ public void testEnabledWhenHover(TestInfo info) throws Exception {
assertNotNull(findControl(shell, StyledText.class, AlrightyHoverProvider.LABEL));
assertNull(findControl(shell, StyledText.class, WorldHoverProvider.LABEL));

// Capture the first shell and its display to wait for disposal
Shell firstShell = shell;
Display display = firstShell.getDisplay();
cleanFileAndEditor();
// Wait for the hover shell to be disposed after editor cleanup
DisplayHelper.waitForCondition(display, 3000, () -> firstShell.isDisposed());

EnabledPropertyTester.setEnabled(false);
createAndOpenFile("enabledWhen.txt", "bar 'bar'");
shell= getHoverShell(info, triggerCompletionAndRetrieveInformationControlManager(), true);
Expand Down
Loading