MultipageEditorPart check for tab disposal when getting Editor #3530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting an editor of a MultpageEditorPart during disposal of the editor led to dispose exceptions as getEditor is accessing an Item's data without checking for disposal. This happened for example when during shutdown the Web-kit widget is sending SWT events. (see eclipse-4diac/4diac-ide#1808 for details). By checking for disposal of the item. This issue is prevent.
azoitl
force-pushed
the
multipageEditorPart
branch
from
910ac81 to
fa72b53
Compare
This was referenced Nov 10, 2025
Harden against selection and update notifications during shutdown #1808
eclipse-4diac/4diac-ide#1811
Merged
Contributor
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting an editor of a MultpageEditorPart during disposal of the editor led to dispose exceptions as getEditor is accessing an Item's data without checking for disposal. This happened for example when during shutdown the Web-kit widget is sending SWT events. (see eclipse-4diac/4diac-ide#1808 for details). By checking for disposal of the item. This issue is prevent.