Skip to content

Fix race condition in ProgressContantsTest.testKeepOneProperty #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2025
+4 −2
Merged

Fix race condition in ProgressContantsTest.testKeepOneProperty #3532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/progress/ProgressContantsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,8 @@ public void testKeepOneProperty() throws Exception {
errorJob.schedule();
processEventsUntil(() -> findProgressInfoItem(errorJob) != null, 3000);
}
// Wait for KEEPONE cleanup to stabilize at exactly 1 item
processEventsUntil(() -> countBelongingProgressItems(DummyFamilyJob.class) == 1, 3000);

assertEquals("Only one finished job should be kept in view", 1,
countBelongingProgressItems(DummyFamilyJob.class));
Expand Down Expand Up @@ -254,8 +256,8 @@ public void testKeepOneProperty() throws Exception {
errorJob.schedule();
processEventsUntil(() -> findProgressInfoItem(errorJob) != null, 3000);
}
// Additional event processing to ensure all KEEPONE logic has completed
processEvents();
// Wait for KEEPONE cleanup to stabilize at exactly 1 item
processEventsUntil(() -> countBelongingProgressItems(DummyFamilyJob.class) == 1, 5000);

assertEquals("Only one finished job should be kept in view", 1,
countBelongingProgressItems(DummyFamilyJob.class));
Expand Down
Loading