Fix flaky FileSearchTests.testBinaryContentTypeWithDescriber race condition #3535
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dition The test was failing intermittently (1 out of 3 runs) due to a race condition in content type registration. The test dynamically registers a binary content type but files were created and searched before the content type was fully available, causing the binary file to be incorrectly included in search results. This fix adds: 1. Explicit wait loop to verify content type is registered before proceeding (up to 500ms with 10ms intervals) 2. Force content type detection on files after creation by calling getContentDescription() to ensure binary signature describer is properly applied Verified with 5 consecutive test runs - all passed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
vogella
force-pushed
the
fix-flaky-binary-content-type-test
branch
2 times, most recently
from
8acd305 to
9a067f2
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
testBinaryContentTypeWithDescriberParallel(1 out of 3 runs failed)Root Cause
The test dynamically registers a binary content type via
registry.addContribution(), then immediately creates files and performs a search. However, content type registration is asynchronous, causing a race where:Changes
FileSearchTests.java:606-629
Wait for content type registration (lines 606-618):
Platform.getContentTypeManager()to verify content type availabilityForce content type detection (lines 626-629):
getContentDescription()on both test files after creationTest Plan
testBinaryContentTypeWithDescriberParallel5 consecutive times - all passedFileSearchTestssuite - all 19 tests passedRelated
Similar race condition fixes in recent commits:
🤖 Generated with Claude Code