Fix traverse in multi page editors

[Christopher-Hermann]

control.traverse on a CTabFolder in the MultiPageEditor is navigation up the the outer CTabFolder itself.

This is causing several issues:
Setting the page for example to the second-to-last is changing the page in the multipage editor. Then the traverse direction is changed causing the outer tab to move in the wrong direction. Furthermore on the outer tab you cannot jump from the last tab to the very first tab.

How to reproduce

1. Open two .java editor and one multi page editor, for example the manifest.
2. On the java editors, traverse to the next tab until you are in the manifest editor
3. In the manifest editor, traverse next tab will not work
4. Traverse to previous tab will jump to the plugin.xml inner tab
5. Traverse to previous again will jump to the java editor

See

traversing.mp4

[Christopher-Hermann]

@fedejeanne I saw that you introduced the fix that enables to navigate from the last to the first tab:

loopToFirstOrLastItem(folder, forward);
traversalDirection = translateToTraversalDirection(!forward); 

Maybe you can have a look on my fix. I'm not really sure if this is really the best solution for the problem. It somehow feels like the wrong place here since control.traverse(traversalDirection) is looping up to the parent controls as well. So now we somehow skip the traverse in multi page editors. Not sure if this is a problem.

Maybe you have an opinion on that, but I guess you are not an expert here as well :D

[github-actions]

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 16m 43s ⏱️ -36s
 8 234 tests ±0   7 985 ✅ ±0  249 💤 ±0  0 ❌ ±0 
23 622 runs  ±0  22 828 ✅ ±0  794 💤 ±0  0 ❌ ±0 

Results for commit adb2a2e. ± Comparison against base commit a3fa065.

[fedejeanne]

Just a guess, but I think you should have navigated all the way to the top with a loop, just to be sure you're navigating on the "Editor Area" and not inside a multi-page editor.

In any case, I plan to merge #3558 and added you and Matthias as co-authors :-)

[fedejeanne]

Just a comment... I'll proceed with #3558 as a joint effort 💪