Skip to content

Deprecate for removal QuickMenuCreator#dispose #3622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 1 commit into from
Jan 3, 2026
Merged

Deprecate for removal QuickMenuCreator#dispose #3622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/actions/QuickMenuAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2004, 2015 IBM Corporation and others.
* Copyright (c) 2004, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -61,7 +61,6 @@ public void run() {
*/
public void dispose() {
if (creator != null) {
creator.dispose();
creator = null;
}
}
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/actions/QuickMenuCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ private int getAverageCharWidth(Control control) {
* {@link #createMenu()} will be disposed shortly after the SWT.Hide
* event.
*/
@Deprecated
@Deprecated(forRemoval = true, since = "2026-03")
public void dispose() {
}
}
3 changes: 1 addition & 2 deletions ...ipse.ui.workbench/eclipseui/org/eclipse/ui/internal/actions/ModifyWorkingSetDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2006, 2015 IBM Corporation and others.
* Copyright (c) 2006, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -164,7 +164,6 @@ public void init(IWorkbenchWindow window) {
public void dispose() {
getWindow().getWorkbench().getWorkingSetManager().removePropertyChangeListener(listener);
super.dispose();
contextMenuCreator.dispose();
}

@Override
Expand Down
3 changes: 1 addition & 2 deletions ...org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/handlers/QuickMenuHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2008, 2015 IBM Corporation and others.
* Copyright (c) 2008, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -65,7 +65,6 @@ public Object execute(ExecutionEvent event) throws ExecutionException {
@Override
public void dispose() {
if (creator != null) {
creator.dispose();
creator = null;
}
}
Expand Down
Loading