Ensure code minings are rendered when editor is initially opened #3689

tobiasmelcher · 2026-01-20T15:40:35Z

This PR fixes a NullPointerException that currently interrupts the code‑mining rendering pipeline. Due to this exception being thrown during editor initialization, no code minings are displayed when the editor is opened.

The problem is fixed by adding a null check for the support field in method call AbstractInlinedAnnotation.isInVisibleLines().

github-actions · 2026-01-20T16:24:08Z

Test Results

2 854 files - 164 2 854 suites - 164 2h 14m 12s ⏱️ - 15m 42s
8 270 tests ± 0 8 019 ✅ - 3 251 💤 + 3 0 ❌ ±0
22 120 runs - 1 514 21 341 ✅ - 1 502 779 💤 - 12 0 ❌ ±0

Results for commit c3bcdf0. ± Comparison against base commit 62f3974.

This pull request skips 3 tests.

AllUnitTests TestUnitWinRegistry ‑ testWinRegistry
JFaceTextTestSuite ContextInformationTest ‑ testContextInfo_hide_focusOut
org.eclipse.urischeme.internal.registration.TestUnitWinRegistry ‑ testWinRegistry

♻️ This comment has been updated with latest results.

vogella · 2026-01-20T19:22:56Z

Should viewer in the constructor maybe also assigned to fViewer? Without knowing to much about the code, it looks weird to me that viewer is passed to the constructor but ignored. Could that result in another NPE?

Suggested fix:

protected AbstractInlinedAnnotation(Position position, ISourceViewer viewer, ...) {
            super(TYPE, false, "");
           this.position = position;
           this.fViewer = viewer; // NEW NEW
            // ...
     }

iloveeclipse · 2026-01-20T19:24:59Z

This PR fixes a NullPointerException that currently interrupts the code‑mining rendering pipeline

Steps to reproduce?

Copilot

Pull request overview

This PR fixes a NullPointerException that prevents code minings from being displayed when an editor is initially opened. The issue occurs when isInVisibleLines() is called before the support field has been initialized via setSupport().

Changes:

Added null checks for the support field in both overloaded isInVisibleLines() methods
Returns true optimistically when support is not yet available, allowing annotations to be rendered during editor initialization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tobiasmelcher · 2026-01-21T11:54:54Z

This PR fixes a NullPointerException that currently interrupts the code‑mining rendering pipeline

Steps to reproduce?

Here the steps to reproduce the problem. Lars has already shown it in eclipse-jdt/eclipse.jdt.ui#2698 (comment).

Enable all code minings for the java editor except "Only if there is at least one result" as shown in the next screenshot.

2. Open a Java editor with a source where the code minings should be visible. The code minings are initially not visible. They become visible when the source is modified. Here a screencast showing the problem scenario:

code_mining_in_java_editor.mp4

Following exception is thrown but not logged when opening the Java editor which stops the code mining to be rendered.

java.lang.NullPointerException: Cannot invoke "org.eclipse.jface.text.source.inlined.InlinedAnnotationSupport.isInVisibleLines(int)" because "this.support" is null
	at org.eclipse.jface.text.source.inlined.AbstractInlinedAnnotation.isInVisibleLines(AbstractInlinedAnnotation.java:254)
	at org.eclipse.jface.internal.text.codemining.CodeMiningLineHeaderAnnotation.isInVisibleLines(CodeMiningLineHeaderAnnotation.java:291)
	at org.eclipse.jface.internal.text.codemining.CodeMiningManager.lambda$13(CodeMiningManager.java:328)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
	at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1939)
	at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762)
	at org.eclipse.jface.internal.text.codemining.CodeMiningManager.renderCodeMinings(CodeMiningManager.java:294)
	at org.eclipse.jface.internal.text.codemining.CodeMiningManager.lambda$1(CodeMiningManager.java:154)
	at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:718)
	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510)
	at java.base/java.util.concurrent.CompletableFuture.postFire(CompletableFuture.java:614)
	at java.base/java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:653)
	at java.base/java.util.concurrent.CompletableFuture$Completion.exec(CompletableFuture.java:483)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)

tobiasmelcher · 2026-01-21T11:59:18Z

Should viewer in the constructor maybe also assigned to fViewer? Without knowing to much about the code, it looks weird to me that viewer is passed to the constructor but ignored. Could that result in another NPE?

Suggested fix:
protected AbstractInlinedAnnotation(Position position, ISourceViewer viewer, ...) {
            super(TYPE, false, "");
           this.position = position;
           this.fViewer = viewer; // NEW NEW
            // ...
     }
 

You are right, this looks weird but is not the reason for the problem. Should I anyhow add the assignment this.fViewer = viewer; in the constructor?
I have added a stacktrace above showing where the problem is raised. I will update the pull request with a change which ensures that such kind of exceptions are visible in future.

iloveeclipse · 2026-01-21T12:08:08Z

Should I anyhow add the assignment this.fViewer = viewer; in the constructor?

No, this deserves extra fix, as the change will be much bigger.

Note: similar to the checks you've added for "support", similar checks must be added for the fViewer code and all callers of getTextWidget() & getViewer() have to be prepared for the "null" widgets.

tobiasmelcher · 2026-01-21T12:23:51Z

Should I anyhow add the assignment this.fViewer = viewer; in the constructor?

No, this deserves extra fix, as the change will be much bigger.

Note: similar to the checks you've added for "support", similar checks must be added for the fViewer code and all callers of getTextWidget() & getViewer() have to be prepared for the "null" widgets.

Ok @iloveeclipse , done with the latest push ([15cbafc]).

....eclipse.jface.text/src/org/eclipse/jface/text/source/inlined/AbstractInlinedAnnotation.java

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningManager.java

vogella · 2026-01-21T14:04:57Z

@iloveeclipse FYI - Gemini code review is in my opinion really good and free, it only needs to be enabled for a repo by the admin. If you start using AI code review you may want to have a look at it (for example by enabling it for your fork)

Gemini Code Review

....eclipse.jface.text/src/org/eclipse/jface/text/source/inlined/AbstractInlinedAnnotation.java

iloveeclipse · 2026-01-21T15:08:13Z

Could you please add this patch on top

diff --git a/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/codemining/ICodeMining.java b/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/codemining/ICodeMining.java
index 17831a6..15150ee 100644
--- a/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/codemining/ICodeMining.java
+++ b/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/codemining/ICodeMining.java
@@ -80,3 +80,3 @@
 	 *
-	 * @param viewer the viewer.
+	 * @param viewer the viewer, can be null
 	 * @param monitor the monitor.
diff --git a/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/inlined/AbstractInlinedAnnotation.java b/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/inlined/AbstractInlinedAnnotation.java
index c2df161..91dee7d 100644
--- a/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/inlined/AbstractInlinedAnnotation.java
+++ b/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/inlined/AbstractInlinedAnnotation.java
@@ -98,2 +98,3 @@
 		this.onMouseMove= onMouseMove;
+		this.fViewer= viewer;
 	}
@@ -164,5 +165,5 @@
 				ISourceViewer viewer= getViewer();
-				if (viewer instanceof ITextViewerExtension5) {
+				if (viewer instanceof ITextViewerExtension5 extViewer) {
 					// adjust offset according folded content
-					offset= ((ITextViewerExtension5) viewer).modelOffset2WidgetOffset(offset);
+					offset= extViewer.modelOffset2WidgetOffset(offset);
 				}

Add a null check for the `support` field in the `AbstractInlinedAnnotation` class to prevent `NullPointerException` when the `isInVisibleLines` method is called. This issue occurs because `support` may not be initialized when the editor is first opened, causing code minings to not render initially.

iloveeclipse · 2026-01-21T17:21:27Z

@tobiasmelcher : thanks.

tobiasmelcher requested a review from vogella January 20, 2026 15:41

tobiasmelcher mentioned this pull request Jan 20, 2026

Fix UI flickering in code mining by adding wait/notify reconciliation coordination eclipse-jdt/eclipse.jdt.ui#2698

Merged

iloveeclipse requested a review from Copilot January 20, 2026 19:24

Copilot started reviewing on behalf of iloveeclipse January 20, 2026 19:30 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

tobiasmelcher force-pushed the add_null_check_for_support_field branch from a81721f to 1c3ad70 Compare January 21, 2026 12:07

tobiasmelcher force-pushed the add_null_check_for_support_field branch from 1c3ad70 to 15cbafc Compare January 21, 2026 12:21

iloveeclipse reviewed Jan 21, 2026

View reviewed changes

....eclipse.jface.text/src/org/eclipse/jface/text/source/inlined/AbstractInlinedAnnotation.java Outdated Show resolved Hide resolved

iloveeclipse requested a review from Copilot January 21, 2026 12:26

Copilot started reviewing on behalf of iloveeclipse January 21, 2026 12:27 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

...org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningManager.java Outdated Show resolved Hide resolved

tobiasmelcher force-pushed the add_null_check_for_support_field branch from 15cbafc to 06851d8 Compare January 21, 2026 12:48

iloveeclipse reviewed Jan 21, 2026

View reviewed changes

....eclipse.jface.text/src/org/eclipse/jface/text/source/inlined/AbstractInlinedAnnotation.java Show resolved Hide resolved

tobiasmelcher force-pushed the add_null_check_for_support_field branch from 06851d8 to c3bcdf0 Compare January 21, 2026 15:38

iloveeclipse approved these changes Jan 21, 2026

View reviewed changes

iloveeclipse merged commit 5802a46 into eclipse-platform:master Jan 21, 2026
21 of 22 checks passed

BeckerWdf assigned tobiasmelcher Jan 21, 2026

BeckerWdf added this to the 4.39 M2 milestone Jan 21, 2026

Ensure code minings are rendered when editor is initially opened #3689

Ensure code minings are rendered when editor is initially opened #3689

Conversation

tobiasmelcher commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

vogella commented Jan 20, 2026

Uh oh!

iloveeclipse commented Jan 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

tobiasmelcher commented Jan 21, 2026

Uh oh!

tobiasmelcher commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iloveeclipse commented Jan 21, 2026

Uh oh!

tobiasmelcher commented Jan 21, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

vogella commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

iloveeclipse commented Jan 21, 2026

Uh oh!

Uh oh!

iloveeclipse commented Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tobiasmelcher commented Jan 20, 2026 •

edited

Loading

github-actions bot commented Jan 20, 2026 •

edited

Loading

tobiasmelcher commented Jan 21, 2026 •

edited

Loading

vogella commented Jan 21, 2026 •

edited

Loading