[Light Theme]Fix for background color of bread-crumb in debug view#1704
Merged
BeckerWdf merged 1 commit intoeclipse-platform:masterfrom Jan 22, 2025
Merged
Conversation
Member
|
Does this PR supersede eclipse-platform/eclipse.platform.ui#2656? |
BeckerWdf
approved these changes
Jan 22, 2025
Member
|
Is a similar fix also needed for the dark theme? |
Contributor
Author
Yes, We have to abandon that PR |
Contributor
Author
Yes, I will do similar changes and create one more PR for dark theme |
Contributor
15 tasks
Member
|
Tested on macOS. Looks good there too. |
Member
|
Thanks for fixing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The background color of bread-crumb items did not match the background color in the debug view, and this has been fixed with this PR. Find the before and after screen shots below for the same.
Before:
After:
