Pay attention to system.lineseparator in XML formatter tests#1712
Merged
akurtakov merged 1 commit intoeclipse-platform:masterfrom Jan 23, 2025
Merged
Pay attention to system.lineseparator in XML formatter tests#1712akurtakov merged 1 commit intoeclipse-platform:masterfrom
akurtakov merged 1 commit intoeclipse-platform:masterfrom
Conversation
Use the helper method to unify on the system line separator.
Member
Author
Contributor
|
As i am not able to reproduce the issue locally i can not verify this will fix it. i'd say just merge to try - if verification builds succeeds. Meanwhile i wonder why the test did not fail in verification tests but only on i-build. Do the i-build use another git autcrlf setting then the verification builds? |
Member
Author
|
That is a question which I can not answer. |
Contributor
Member
Author
|
Merged, let's see next I-build results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the helper method to unify on the system line separator.