Enhance the IContributionFactory to filter contributions#1719
Merged
laeubi merged 1 commit intoeclipse-platform:masterfrom Jan 31, 2025
Merged
Conversation
Currently there is no way for filtering a contribution to the model on a global level. This adds a new method to IContributionFactory#isEnabled that allows extenders to mark a given contribution as being disabled. See eclipse-platform/eclipse.platform.ui#2217
laeubi
force-pushed
the
add_support_for_filtering_of_contributions
branch
from
3a6fca6 to
f74aa98
Compare
jukzi
reviewed
Feb 4, 2025
|
|
||
| Bundle getBundle(String uriString); | ||
|
|
||
| default boolean isEnabled(String uriString) { |
Contributor
There was a problem hiding this comment.
I wonder why this added API did not need a @since javadoc
Contributor
Author
There was a problem hiding this comment.
Because it is only provisional (non public) API
Contributor
There was a problem hiding this comment.
Thanks, i did not have in mind x-friends declares provisional APIs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no way for filtering a contribution to the model on a global level.
This adds a new method to IContributionFactory#isEnabled that allows extenders to mark a given contribution as being disabled.
See eclipse-platform/eclipse.platform.ui#2217