Skip to content

Help search: Make the number of max hits before filtering configurable #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iloveeclipse merged 1 commit into from
Feb 11, 2025
Merged

Help search: Make the number of max hits before filtering configurable #1737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ua/org.eclipse.help.base/preferences.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,12 @@ maxConnections=10
# Example: maxTopics=
maxTopics=500

# Max number of topics to be searched for before filtering is applied
# If the number is too small, hits may be missed when searching e.g. in a topic and its subtopics
# The higher the number, the slightly worse the performance
# Assign a value greater than maxTopics (see above), but no greater than Integer.MAX_VALUE
maxHitsBeforeFiltering=1000

#########################
# Search Results
#########################
Expand Down
5 changes: 4 additions & 1 deletion ua/org.eclipse.help.base/src/org/eclipse/help/internal/search/SearchIndex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@
*/
public class SearchIndex implements IHelpSearchIndex {

private static final int MAX_HITS_BEFORE_FILTERING = Platform.getPreferencesService()
.getInt(HelpBasePlugin.PLUGIN_ID, "maxHitsBeforeFiltering", 1_000, null); //$NON-NLS-1$

private IndexReader ir;

private IndexWriter iw;
Expand Down Expand Up @@ -662,7 +665,7 @@ public void search(ISearchQuery searchQuery, ISearchHitCollector collector) thro
}
if (luceneQuery == null)
return;
TopDocs topDocs = searcher.search(luceneQuery, 1000);
TopDocs topDocs = searcher.search(luceneQuery, MAX_HITS_BEFORE_FILTERING);
collector.addHits(LocalSearchManager.asList(topDocs, searcher), queryBuilder.gethighlightTerms());
} catch (IndexSearcher.TooManyClauses tmc) {
collector.addQTCException(new QueryTooComplexException());
Expand Down
Loading