Support alternative PageBookViewPage for console through adapter pattern#1764
Merged
laeubi merged 1 commit intoeclipse-platform:masterfrom Mar 9, 2025
Merged
Conversation
Currently one can supply alternative processes through IProcessFactory's but all of such processes must currently be a textconsole there is no way to supply an alternative or enhanced UI. This now uses the adapter pattern to support supply an alternative PageBookViewPage that is used to display the console.
Contributor
Test Results 1 600 files 1 600 suites 1h 26m 6s ⏱️ Results for commit 7704fb1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently one can supply alternative processes through IProcessFactory's but all of such processes must currently be a textconsole there is no way to supply an alternative or enhanced UI.
This now uses the adapter pattern to support supply an alternative PageBookViewPage that is used to display the console.
See