Update FAQ related to Edge and Internet Explorer#1796
Update FAQ related to Edge and Internet Explorer#1796HeikoKlare merged 1 commit intoeclipse-platform:masterfrom
Conversation
| In case you want to use fixed-version binaries or override the automatically chosen version, set the `org.eclipse.swt.browser.EdgeDir` Java property to the directory containing `msedgewebview2.exe`. For example: | ||
|
|
||
| ```sh | ||
| java "-Dorg.eclipse.swt.browser.EdgeDir=C:\Program Files (x86)\Microsoft\Edge Beta\Application\88.0.705.29" ... |
There was a problem hiding this comment.
Starting Eclipse via a java command isn't that common.
Should the example just mention the 'system property' and not give a command line example?
Or, alternatively, mention to modify the eclipse.ini`
There was a problem hiding this comment.
Makes sense. This is probably only relevant when having a pure SWT application. I have reduced this to a sentence mentioning the system property and referring to the eclipse.ini for Eclipse products.
docs/FAQ/FAQ_How_do_I_use_Edge-IE_as_the_Browser's_underlying_renderer.md
Outdated
Show resolved
Hide resolved
| _Note: As of Eclipse/SWT 4.8, Mozilla (`XULRunner`) renderer is no longer supported, the value `mozilla` has no effect._ | ||
|
|
||
| A user can specify a comma-separated list of native renderers, in order of preference, for the `org.eclipse.swt.browser.DefaultType` value. Values not applicable to a particular platform are ignored. For example, the value of `edge,chromium` will change the default to Edge on Windows and Chromium on other platforms. | ||
| A user can specify a comma-separated list of native renderers, in order of preference, for the `org.eclipse.swt.browser.DefaultType` value. Values not applicable to a particular platform are ignored. For example, the value of `ie,chromium` will change the default to Internet Explorer on Windows and Chromium on other platforms. |
There was a problem hiding this comment.
seeing as chromium is not supported anymore, should we replace this constant with webkit?
There was a problem hiding this comment.
Done. I also added the deprecation information to the where the CHROMIUM flag is mentioned.
|
LGTM |
|
Thanks for your feedback! I adapted everything accordingly. |
Follow up to:
A "rendered" version of the primary changed FAQ page can be found here: https://github.com/HeikoKlare/eclipse.platform/blob/edge-faq/docs/FAQ/FAQ_How_do_I_use_Edge-IE_as_the_Browser's_underlying_renderer.md