Add SVGs to org.eclipse.compare bundles#1812
Add SVGs to org.eclipse.compare bundles#1812HeikoKlare merged 2 commits intoeclipse-platform:masterfrom Michael5601:Compare-SVGs
Conversation
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
HeikoKlare
left a comment
There was a problem hiding this comment.
In general, the change looks good. I only found that the plugin.properties in the org.eclipse.compare bundle still contains references to PNG files (for which also SVG files exist). Is that intentional or by accident, @Michael5601?
Thanks for the review :) The leftover png references in the |
This commit adds SVGs for all icons in the bundles `org.eclipse.compare`, `org.eclipse.compare.tests` and `org.eclipse.compare.win32`.
|
Merging this despite Jenkins failure caused by https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5892 Since master builds seem to still work on Jenkins, the subsequent master build should hopefully work, thus I will check results of that build to retrospectively validate this PR. |
|
No new issues on subsequent master build for 9698efe |
This PR adds SVGs for all icons in the bundles
org.eclipse.compare,org.eclipse.compare.testsandorg.eclipse.compare.win32.See also this PR for more information.