-
Notifications
You must be signed in to change notification settings - Fork 147
Add SVGs to org.eclipse.compare bundles #1812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b634215
to
702d456
Compare
This pull request changes some projects for the first time in this development cycle.
An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patch
Further information are available in Common Build Issues - Missing version increments. |
7bf91b0
to
6450334
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, the change looks good. I only found that the plugin.properties
in the org.eclipse.compare
bundle still contains references to PNG files (for which also SVG files exist). Is that intentional or by accident, @Michael5601?
6450334
to
950fb34
Compare
Thanks for the review :) The leftover png references in the |
950fb34
to
26cf060
Compare
This commit adds SVGs for all icons in the bundles `org.eclipse.compare`, `org.eclipse.compare.tests` and `org.eclipse.compare.win32`.
26cf060
to
5cc704d
Compare
Merging this despite Jenkins failure caused by https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5892 Since master builds seem to still work on Jenkins, the subsequent master build should hopefully work, thus I will check results of that build to retrospectively validate this PR. |
No new issues on subsequent master build for 9698efe |
This PR adds SVGs for all icons in the bundles
org.eclipse.compare
,org.eclipse.compare.tests
andorg.eclipse.compare.win32
.See also this PR for more information.