Skip to content

Add SVGs to org.eclipse.ui.externaltools #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025

Conversation

Michael5601
Copy link
Contributor

This PR adds SVGs for all icons in the bundle org.eclipse.ui.externaltools except for the following as it is not available as SVG yet:

wizban/ext_tools_wiz.svg

See also this PR for more information.

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

debug/org.eclipse.ui.externaltools/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 33dc125478f7655bac701edad8f39675fb582ee4 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 14 Apr 2025 08:31:15 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/debug/org.eclipse.ui.externaltools/META-INF/MANIFEST.MF b/debug/org.eclipse.ui.externaltools/META-INF/MANIFEST.MF
index 7c670dc4d2..b0aaba767b 100644
--- a/debug/org.eclipse.ui.externaltools/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.ui.externaltools/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.externaltools; singleton:=true
-Bundle-Version: 3.6.500.qualifier
+Bundle-Version: 3.6.600.qualifier
 Bundle-Activator: org.eclipse.ui.externaltools.internal.model.ExternalToolsPlugin
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

github-actions bot commented Apr 14, 2025

Test Results

 1 758 files  ±0   1 758 suites  ±0   1h 27m 32s ⏱️ - 9m 26s
 4 173 tests ±0   4 150 ✅ ±0   23 💤 ±0  0 ❌ ±0 
13 119 runs  ±0  12 952 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 57cd277. ± Comparison against base commit ba714d3.

♻️ This comment has been updated with latest results.

@Michael5601 Michael5601 force-pushed the UI-ExternalTools-SVG branch from 0dc0263 to 2d71c87 Compare April 15, 2025 09:06
Michael5601 and others added 2 commits April 24, 2025 19:50
This commit adds SVGs for all icons in the bundle org.eclipse.ui.externaltools except for the following as these are not available as SVG yet:

wizban/ext_tools_wiz.svg
@HeikoKlare HeikoKlare force-pushed the UI-ExternalTools-SVG branch from 2d71c87 to 57cd277 Compare April 24, 2025 17:50
@HeikoKlare
Copy link
Contributor

Version increment check is failing for infrastructure reasons and necessary version bump commit has already been added to this PR before.

@HeikoKlare HeikoKlare merged commit 28a2773 into eclipse-platform:master Apr 24, 2025
10 of 11 checks passed
@Michael5601 Michael5601 deleted the UI-ExternalTools-SVG branch April 25, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants