Skip to content

Add SVGs to org.eclipse.debug.ui.launchview #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Michael5601
Copy link
Contributor

This PR adds SVGs for all icons in the bundle org.eclipse.debug.ui.launchview except for the following as these are not available as SVG yet:

coverage.svg
delete_exc.svg
favorite_star.svg

See also this PR for more information.

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

debug/org.eclipse.debug.ui.launchview/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 303c6ef82ec7b36bdfd06c7ff109ce87852760ba Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 14 Apr 2025 08:59:19 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/debug/org.eclipse.debug.ui.launchview/META-INF/MANIFEST.MF b/debug/org.eclipse.debug.ui.launchview/META-INF/MANIFEST.MF
index 1a8451e6b1..88e8046f0b 100644
--- a/debug/org.eclipse.debug.ui.launchview/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.debug.ui.launchview/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.debug.ui.launchview;singleton:=true
-Bundle-Version: 1.1.700.qualifier
+Bundle-Version: 1.1.800.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.ui,
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

github-actions bot commented Apr 14, 2025

Test Results

 1 758 files  ±0   1 758 suites  ±0   1h 33m 40s ⏱️ +49s
 4 173 tests ±0   4 150 ✅ ±0   23 💤 ±0  0 ❌ ±0 
13 119 runs  ±0  12 952 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 5e2f4a1. ± Comparison against base commit 28a2773.

♻️ This comment has been updated with latest results.

Michael5601 and others added 2 commits April 24, 2025 21:04
This commit adds SVGs for all icons in the bundle `org.eclipse.debug.ui.launchview` except for the following as these are not available as SVG yet:

coverage.svg
delete_exc.svg
favorite_star.svg
@HeikoKlare HeikoKlare force-pushed the org.eclipse.debug.ui.launchview.SVGs branch from d0dd6ca to 5e2f4a1 Compare April 24, 2025 19:04
@HeikoKlare
Copy link
Contributor

Version increment check is failing for infrastructure reasons and necessary version bump commit has already been added to this PR before.

@HeikoKlare HeikoKlare merged commit 89a86a1 into eclipse-platform:master Apr 24, 2025
10 of 11 checks passed
@Michael5601 Michael5601 deleted the org.eclipse.debug.ui.launchview.SVGs branch April 25, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants