Remove hover images and replace faulty icon in org.eclipse.ui.console #1837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hover images only replicate the ordinary icons without giving any benefit but just duplicate resources. One of the just added SVGs icons (for wordwrap) is even incorrect. This change completely removes the hover images in org.eclipse.ui.console, including their code usages and the just provisioned SVGs.
|
Failing version increment check is for infrastructure reasons and necessary version bump has already been made via #1813 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hover images only replicate the ordinary icons without giving any benefit but just duplicate resources. One of the just added SVGs icons (for wordwrap) is even incorrect (it's different version of the
wordwrapicon, so that original and hover icon are slightly different). This change completely removes the hover images in org.eclipse.ui.console, including their code usages and the just provisioned SVGs.Before:
After:
