Skip to content

Comments

Remove usages of deprecated fastViewWidthRatio#1840

Merged
HeikoKlare merged 1 commit intoeclipse-platform:masterfrom
HeikoKlare:remove-fastViewWidthRatio
May 9, 2025
Merged

Remove usages of deprecated fastViewWidthRatio#1840
HeikoKlare merged 1 commit intoeclipse-platform:masterfrom
HeikoKlare:remove-fastViewWidthRatio

Conversation

@HeikoKlare
Copy link
Contributor

Some plugins contained definitions of fastViewWidthRatio even though that value is not read for a while and was just deprecated. This change removes those definitions.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025

Test Results

 1 758 files  ±0   1 758 suites  ±0   1h 32m 31s ⏱️ + 6m 54s
 4 173 tests ±0   4 150 ✅ ±0   23 💤 ±0  0 ❌ ±0 
13 119 runs  ±0  12 952 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 42d7918. ± Comparison against base commit 02ffafb.

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare force-pushed the remove-fastViewWidthRatio branch from ea0adea to c2dbdd5 Compare April 26, 2025 14:14
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

debug/org.eclipse.unittest.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From d545e9fbe98cda70e947e9bf1dbe666f889e4db3 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Sat, 26 Apr 2025 14:20:54 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/debug/org.eclipse.unittest.ui/META-INF/MANIFEST.MF b/debug/org.eclipse.unittest.ui/META-INF/MANIFEST.MF
index f6aec99b11..54597f9691 100644
--- a/debug/org.eclipse.unittest.ui/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.unittest.ui/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.unittest.ui
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.unittest.ui;singleton:=true
-Bundle-Version: 1.1.500.qualifier
+Bundle-Version: 1.1.600.qualifier
 Bundle-Activator: org.eclipse.unittest.internal.UnitTestPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Some plugins contained definitions of fastViewWidthRatio even though
that value is not read for a while and was just deprecated. This change
removes those definitions.
@ptziegler ptziegler force-pushed the remove-fastViewWidthRatio branch from e0f8abb to 42d7918 Compare May 8, 2025 18:26
Copy link
Contributor

@ptziegler ptziegler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. I didn't notice that the platform also contains UI contributions. Otherwise I would've updated them myself when I deprecated the attribute.

@vogella
Copy link
Contributor

vogella commented May 9, 2025

LGTM, please merge

@HeikoKlare HeikoKlare merged commit 55642ec into eclipse-platform:master May 9, 2025
20 of 22 checks passed
@HeikoKlare HeikoKlare deleted the remove-fastViewWidthRatio branch May 9, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants