Merge terminal control #1851
Merged
Merge terminal control #1851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ibab77ef2ba53f4fd91363269330955eca5fd2bb3 Signed-off-by: nickboldt <[email protected]>
…rsion everything to 4.5.0 and fix plugin deps to use new version; fix versions of dstore plugins Change-Id: Ic5dd336a22e822e848b9fe63f02029c24bd0bf08 Signed-off-by: nickboldt <[email protected]>
…part 2 Change-Id: Ifa14f8b829bf1859e36ffce719e6cfac14012236 Signed-off-by: nickboldt <[email protected]>
Change-Id: I5ef20c1c81c17896e3c73ae0aa8c6cf47a708016 Signed-off-by: nickboldt <[email protected]>
Change-Id: I99acb204f490355d91a4de3f4233329246a0b9d0 Signed-off-by: nickboldt <[email protected]>
…Serial command shells are opened Buglink: https://bugs.eclipse.org/bugs/show_bug.cgi?id=549013 Signed-off-by: Julien Dehaudt <[email protected]>
Change-Id: I12c461c9d05241629442ae84ea1c2f439a23039d Signed-off-by: nickboldt <[email protected]>
Change-Id: I1481ac53d6bd5a0c66eced40acfa77a51c3c73f4 Signed-off-by: nickboldt <[email protected]>
Change-Id: I46db42560ec0b93bb265f45920d78c97a32338c3
Change-Id: I274a6e5f985d60d1ae6fc929af3eb0fdcea868ba
Change-Id: Ib63f010cf5e741beb6a77096e958ab5478133635
Change-Id: I4b8ca8341a3f479a74a06621f68534732cff6957
This is applying the per-project code formatting rules that would be applied on save in the JDT editor See also Bug 540373 Change-Id: Id04c972c3b3cb0a6ed1ab8581185359b7cf43f91
The 4.6.0 version marks the first version of terminal built in CDT and in a different git repo - there are no API changes. Change-Id: Ic6c4089d7e6ccbb2701bf59fedba2b6a8dd4c856
It is now Eclipse CDT providing these, so update to match Change-Id: I1bc83b77d491d1475db51cbb6396571893d8ee42
Change-Id: I55b5fcce4948ec17a97a199bb75627e8e7a4c462 Signed-off-by: Alexander Kurtakov <[email protected]>
Change-Id: I2cd3dad7821e3c6ae3f0371edda5e511beff4014 Signed-off-by: Alexander Kurtakov <[email protected]>
Change-Id: I9248a3fd2481b590e8437bf7f880f936ba88ce6c Signed-off-by: Alexander Kurtakov <[email protected]>
Change-Id: I30c23a89b3e78306d3e05fa65f5d2d8dd9e23540 Signed-off-by: Alexander Kurtakov <[email protected]>
And run save actions to modernize code a bit. Change-Id: I4a718e73e8472679aa4ead7fdefe4259004ef6d6 Signed-off-by: Alexander Kurtakov <[email protected]>
constructor. Change-Id: Iab91e05314206725d8175d30bfb2866c0d99a8d7 Signed-off-by: Alexander Kurtakov <[email protected]>
This is done by buffering the drawing of the line of the terminal. Change-Id: I593a3b99080d779046ea37497d93a25584c472c1
Change-Id: Ief69751ba4affc13240cfdb4b79e190b3356bbd9
…xup) Dispose of the image used for buffering GC. Change-Id: I80b6edea3211847265140aa8992546a16474cadf
… event The original code used the direction provided by the scroll wheel, but not the magnitude. Change-Id: I7f5e2083599990f4f4999aba46ef38602b9fe565
Change-Id: Ibb31fa697065add6d3341faf5bdc84e24504e1e3
The inconsistency of lower case and upper case in the internal representation of the colour names made it harder than it should be to find where colours are used in the code. Note that the SytleMap creates lower and uppercase entries for each colour. Change-Id: I16b4ebe4a97adecd01f835319aa0f0d175ae3bb6
This may need to change to an LRU cache if we end up with too many potential styles Change-Id: I66bb6a4b9f67c6fd8656875f138899dd3a67a360
GC.getForeground / Background always create a new Color object, so this if expression was always true. Change-Id: Ief4ccaf1adb70967301411b012c0474608f425cb
There are two ways of specifying fonts in the terminal, one via font definitions, and one via the font directly. The method via the font directly was already deprecated in the public API, this commit follows that deprecation chain through to make it easier to identify which code paths are not likely relevant anymore. These methods could simply be removed as part of the major version bump. Change-Id: I05d746c429c4e6c3ced5ee7bb7a6172e0a255c2d
When a more complete implementation of ANSI Escape sequence for renaming terminal titles was added in [CDT 10.2](https://github.com/eclipse-cdt/cdt/blob/main/NewAndNoteworthy/CDT-10.2.md#rename-terminal-tab) it caused a regression in use cases where extenders of the terminal wanted to retain control of the terminal's title. This commit adds a new flag that will prevent the title of the terminal tab from being updated from ANSI escape sequences. Fixes eclipse-platform#494
This escape sequence can be generated when using Powershell on Windows (and possibly other places too) to erase number of characters. Change-Id: I32405f51a3f91fd8653d44f2676a5c85b696ef99
…pse-platform#619) Includes a new system property `org.eclipse.tm.terminal.control.convertBackspace` to allow us to disable this new behaviour in the field if it turns out that some terminal/host combination does not like this conversion. Fixes eclipse-platform#392
* remove invalid tycho resolver config (not valid since many versions) * fix PMD plugin configuration (config attribute was renamed in 3.18) * remove duplicate versions already managed in pluginManagement section * fix indentation * move all not yet configured versions into pluginManagement of the parent module to avoid further duplication * consume the target platform as file, not as maven artifact (this simplifies building a single module A LOT) * remove invalid tycho-source-plugin configuration * disable tycho consumer POM generation (not needed here, and avoids a warning in each module) * remove prerequisites. that's for maven plugins only, and this POM already contains the better suited similar maven enforcer rule * enforce UTF-8 for javadoc generation (the build fails on Windows otherwise, trying to read some Japanese? characters with the Windows default encoding)
This fixes support to properly identify the end of OSC control sequences which can be terminated with a BEL or ESC \. Fixes eclipse-cdt/cdt#831
the rest of Eclipse now uses UTF-8 as default encoding. The tm.terminal code reverts to null when the encoding begins with "Default" and this leads to UTF-8 being selected from Charset.defaultEncoding instead of ISO-8859 when the displayed default value is selected. Co-authored-by: Philipp SALZGEBER <[email protected]>
Closed
Contributor
laeubi
force-pushed
the
merge_terminal_control
branch
2 times, most recently
from
d981881 to
0928f9b
Compare
laeubi
force-pushed
the
merge_terminal_control
branch
from
0928f9b to
17979af
Compare
merks
approved these changes
May 5, 2025
Contributor
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
I have not reviewed in detail. But I've seen the discussion and I think folks are comfortable with the plan to migrate this to the platform so that it can be more widely reused.
Member
|
@laeubi : Do you plan to migrate tests or to provide new tests for that bundle? |
Contributor
Author
|
There is a test-suite here: but it covers more aspects that the control itself. If things work out well we should migrate more parts (e.g. terminal view and connectors) so probably also the tests. |
jonahgraham
added a commit
to eclipse-cdt/cdt
that referenced
this pull request
May 19, 2025
The new location of this bundle's source is https://github.com/eclipse-platform/eclipse.platform/tree/master/terminal/plugins/org.eclipse.tm.terminal.control It was mirgated to platform in: eclipse-platform/eclipse.platform#1851 as part of the work to achieve eclipse-platform/eclipse.platform#1762
jonahgraham
added a commit
to eclipse-cdt/cdt
that referenced
this pull request
May 19, 2025
The new location of this bundle's source is https://github.com/eclipse-platform/eclipse.platform/tree/master/terminal/plugins/org.eclipse.tm.terminal.control It was mirgated to platform in: eclipse-platform/eclipse.platform#1851 as part of the work to achieve eclipse-platform/eclipse.platform#1762
jonahgraham
added a commit
to eclipse-cdt/cdt
that referenced
this pull request
May 19, 2025
The new location of this bundle's source is https://github.com/eclipse-platform/eclipse.platform/tree/master/terminal/plugins/org.eclipse.tm.terminal.control It was mirgated to platform in: eclipse-platform/eclipse.platform#1851 as part of the work to achieve eclipse-platform/eclipse.platform#1762
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the terminal control currently located at CDT to platform see:
From the readme:
FYI @akurtakov @jonahgraham @stbischof