Skip to content

Conversation

@merks
Copy link
Contributor

@merks merks commented May 4, 2025

  • There are no svg images in that folder because the disabled image is synthesized from the regular image.

#1852

- There are no svg images in that folder because the disabled image is
synthesized from the regular image.

eclipse-platform#1852
@merks
Copy link
Contributor Author

merks commented May 4, 2025

This fixes the problem and we see proper disabled images:

image

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2025

Test Results

 1 758 files  ±0   1 758 suites  ±0   1h 34m 1s ⏱️ + 2m 44s
 4 173 tests ±0   4 149 ✅  - 1   23 💤 ±0  1 ❌ +1 
13 119 runs  ±0  12 949 ✅  - 3  167 💤 ±0  3 ❌ +3 

For more details on these failures, see this check.

Results for commit 6663ed7. ± Comparison against base commit 86aa0ac.

@merks
Copy link
Contributor Author

merks commented May 4, 2025

The failures are known:

eclipse-equinox/equinox#937

@merks merks merged commit f35c81b into eclipse-platform:master May 4, 2025
11 of 18 checks passed
@merks merks deleted the issue-1852 branch May 4, 2025 11:14
@HeikoKlare
Copy link
Contributor

Thank you for the fix, @merks! This is the right thing to do. The pre-generated disabled images became obsolete with eclipse-platform/eclipse.platform.swt#1936, as they are now generated on-the-fly with the same result/quality. This was a preparation for the SVG support, as it made the provision of disabled icon SVGs obsolete. I tried to adapt all references to disabled icons together with the SVG-introducing PRs, but seems like a missed at least this place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants