Migrate org.eclipse.e4.core.tests to JUnit 5 (javax + jakarta variant)

[ptziegler]

No description provided.

[github-actions]

Test Results

 1 764 files  +  6   1 764 suites  +6   1h 29m 12s ⏱️ + 3m 35s
 4 381 tests +208   4 357 ✅ +207   24 💤 +1  0 ❌ ±0 
13 143 runs  + 24  12 976 ✅ + 24  167 💤 ±0  0 ❌ ±0 

Results for commit 3aaa3cf. ± Comparison against base commit 02ffafb.

This pull request removes 210 and adds 418 tests. Note that renamed tests count towards both.

CoreTestSuite org.eclipse.e4.core.internal.tests.about.AboutTest ‑ testAppendInstalledBundles
CoreTestSuite org.eclipse.e4.core.internal.tests.about.AboutTest ‑ testAppendInstalledFeatures
CoreTestSuite org.eclipse.e4.core.internal.tests.about.AboutTest ‑ testAppendUserPreferences
CoreTestSuite org.eclipse.e4.core.internal.tests.about.AboutTest ‑ testCreateSectionFilter
CoreTestSuite org.eclipse.e4.core.internal.tests.about.AboutTest ‑ testMaskPassword
CoreTestSuite org.eclipse.e4.core.internal.tests.about.AboutTest ‑ testMultilineValue
CoreTestSuite org.eclipse.e4.core.internal.tests.about.AboutTest ‑ testSystemEnvironmentVariables
CoreTestSuite org.eclipse.e4.core.internal.tests.about.AboutTest ‑ testSystemProperties
CoreTestSuite org.eclipse.e4.core.internal.tests.about.InstalledFeaturesTest ‑ testInstalledFeatures
CoreTestSuite org.eclipse.e4.core.internal.tests.contexts.ActivationTest ‑ testContextActivation
…

CoreTestSuite (javax) ActivationInjectionTest ‑ testActivationInjection
CoreTestSuite (javax) ActivationInjectionTest ‑ testContextActivation
CoreTestSuite (javax) ActivationInjectionTest ‑ testInjection
CoreTestSuite (javax) ActivationTest ‑ testContextActivation
CoreTestSuite (javax) ActivationTest ‑ testGetActive
CoreTestSuite (javax) ActivationTest ‑ testGetActiveBug384425
CoreTestSuite (javax) ActivationTest ‑ testGetActiveRAT
CoreTestSuite (javax) ActivationTest ‑ testGetActiveRATNumberOfCalls
CoreTestSuite (javax) ActivationTest ‑ testGetActiveRATNumberOfCalls2
CoreTestSuite (javax) AnnotationsInjectionTest ‑ testContextSetOneArg
…

This pull request removes 1 skipped test and adds 2 skipped tests. Note that renamed tests count towards both.

CoreTestSuite org.eclipse.e4.core.internal.tests.di.extensions.ServiceSupplierTestCase ‑ testUselessUpdates

CoreTestSuite (javax) ServiceSupplierTestCase ‑ testUselessUpdates
CoreTestSuite ServiceSupplierTestCase ‑ testUselessUpdates

♻️ This comment has been updated with latest results.

[ptziegler]

Both test suites have 418 test in total, but the test suites now have different names. Partially because of Junit 5 and partially because I gave the javax variant a dedicated name, to avoid any further confusion.

[ptziegler]

Everything looks good now. Unless there are any objections, I plan on merging later today.

[merks]

Sounds great!!

[HannesWell]

Thank you for working on this.
In general this looks good to me, I just have two minor remarks.

[HannesWell]

Thank you for the updates.
The changes look good to me, although I have not reviewed each and every detail, but since all tests pass and the number of tests has even increased (in total), I think this is fine.

[vogella]

LGTM Thanks @ptziegler