Skip to content

Comments

Clean Code for resources/bundles/org.eclipse.core.filesystem#1914

Merged
akurtakov merged 2 commits intomasterfrom
clean-code/resources/bundles/org.eclipse.core.filesystem
Jun 7, 2025
Merged

Clean Code for resources/bundles/org.eclipse.core.filesystem#1914
akurtakov merged 2 commits intomasterfrom
clean-code/resources/bundles/org.eclipse.core.filesystem

Conversation

@eclipse-platform-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-platform-bot
Copy link
Contributor Author

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

resources/bundles/org.eclipse.core.filesystem/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From c184418c8102d645ba634cc49639efcd1738f6f0 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Sat, 7 Jun 2025 03:16:15 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/resources/bundles/org.eclipse.core.filesystem/META-INF/MANIFEST.MF b/resources/bundles/org.eclipse.core.filesystem/META-INF/MANIFEST.MF
index 3193b8a064..62198db331 100644
--- a/resources/bundles/org.eclipse.core.filesystem/META-INF/MANIFEST.MF
+++ b/resources/bundles/org.eclipse.core.filesystem/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.core.filesystem; singleton:=true
-Bundle-Version: 1.11.200.qualifier
+Bundle-Version: 1.11.300.qualifier
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.equinox.common;bundle-version="[3.18.0,4.0.0)",
  org.eclipse.equinox.registry;bundle-version="[3.2.0,4.0.0)",
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2025

Test Results

 1 893 files  +129   1 893 suites  +129   1h 30m 30s ⏱️ + 1m 21s
 4 381 tests ±  0   4 357 ✅ ±  0   24 💤 ±0  0 ❌ ±0 
13 143 runs  ±  0  12 976 ✅ ±  0  167 💤 ±0  0 ❌ ±0 

Results for commit 77d4263. ± Comparison against base commit 1be0f85.

@akurtakov akurtakov merged commit 9d6deb4 into master Jun 7, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/resources/bundles/org.eclipse.core.filesystem branch June 7, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants