Skip to content

Clean Code for runtime/bundles/org.eclipse.core.runtime#1921

Merged
akurtakov merged 2 commits intomasterfrom
clean-code/runtime/bundles/org.eclipse.core.runtime
Jun 9, 2025
Merged

Clean Code for runtime/bundles/org.eclipse.core.runtime#1921
akurtakov merged 2 commits intomasterfrom
clean-code/runtime/bundles/org.eclipse.core.runtime

Conversation

@eclipse-platform-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-platform-bot
Copy link
Contributor Author

eclipse-platform-bot commented Jun 8, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From d1cd3f07239505011b2f704e7092bfdfc1936afb Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Mon, 9 Jun 2025 03:35:45 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
index ed76b75691..2a257ed6c0 100644
--- a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
+++ b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
-Bundle-Version: 3.33.100.qualifier
+Bundle-Version: 3.33.200.qualifier
 Bundle-SymbolicName: org.eclipse.core.runtime; singleton:=true
 Bundle-Vendor: %providerName
 Bundle-Activator: org.eclipse.core.internal.runtime.PlatformActivator
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2025

Test Results

 1 893 files  ±0   1 893 suites  ±0   1h 30m 47s ⏱️ -35s
 4 381 tests ±0   4 357 ✅ ±0   24 💤 ±0  0 ❌ ±0 
13 143 runs  ±0  12 976 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit ef97eda. ± Comparison against base commit d66de99.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/runtime/bundles/org.eclipse.core.runtime branch from 7ea682b to d2cb313 Compare June 9, 2025 03:29
@akurtakov akurtakov merged commit 61cd046 into master Jun 9, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/runtime/bundles/org.eclipse.core.runtime branch June 9, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants