Migrate org.eclipse.tm.terminal.view.core#1959
Closed
laeubi wants to merge 66 commits intoeclipse-platform:masterfrom
Closed
Migrate org.eclipse.tm.terminal.view.core#1959laeubi wants to merge 66 commits intoeclipse-platform:masterfrom
laeubi wants to merge 66 commits intoeclipse-platform:masterfrom
Conversation
directory of the editor in focus
when a selection is made
Change-Id: I853b3ffcc58724dc0733dfc89ee9162e8b2219b1 Signed-off-by: Martin Oberhuber <martin.oberhuber@windriver.com>
…cted once the process terminated
marketplace/tcf-terminals
Enable API Analysis on all Terminal Connectors, and mark o.e.tm.terminal.control/provisional/api as API in MANIFEST.MF such that full API Analysis is available on our de-facto API. Since the conversion of provisional.api to full API triggers errors, this needs a patched 4.0 baseline to properly compare against. Use http://archive.eclipse.org/tm/downloads/tm_4.0_api_baseline.zip for analysis in 4.1 -- after 4.1 a normal baseline will do. Change-Id: Ibbc2addd59a629d45f676a97339bf27bba07014e Signed-off-by: Martin Oberhuber <martin.oberhuber@windriver.com>
error: unexpected end of file" ??
Change-Id: I5524741a709c0c5cdd8860561de0992ff9aa75b6
All features are upreved to 4.3 along with the Parent POM for the upcoming Terminal 4.3 / Oxygen release. Plugin versions remain unchanged, keeping them as semantic versions. Along the lines, also - Introduce a Maven Profile -Pcdtserial, which is active by default to build the cdtserial plug-ins. This can be de-activated by property -Dnocdtserial on the mvn command-line. This is necessary to build / validate Terminal against older streams (juno,mars,...,neon) which did not have the necessary cdt native serial dependency. - Update the update site to http://download.eclipse.org/tm/terminal/updates/4.3 - Update Copyright Year in all features to 2017 - Update p2 repo URLs of Oxygen and Orbit dependencies. - Update the terminals.psf project-set file adding the new cdtserial. Change-Id: I8992fe4bb8ac08abe783d33fbb8b00b4e864fd73 Signed-off-by: Martin Oberhuber <martin.oberhuber@windriver.com>
Change-Id: Ib5fc22afc25f13690c67e316194da77c224a13af Signed-off-by: Martin Oberhuber <mober.at+eclipse@gmail.com>
Change-Id: Ibab77ef2ba53f4fd91363269330955eca5fd2bb3 Signed-off-by: nickboldt <nboldt@redhat.com>
…rsion everything to 4.5.0 and fix plugin deps to use new version; fix versions of dstore plugins Change-Id: Ic5dd336a22e822e848b9fe63f02029c24bd0bf08 Signed-off-by: nickboldt <nboldt@redhat.com>
…part 2 Change-Id: Ifa14f8b829bf1859e36ffce719e6cfac14012236 Signed-off-by: nickboldt <nboldt@redhat.com>
Change-Id: I5ef20c1c81c17896e3c73ae0aa8c6cf47a708016 Signed-off-by: nickboldt <nboldt@redhat.com>
Change-Id: I99acb204f490355d91a4de3f4233329246a0b9d0 Signed-off-by: nickboldt <nboldt@redhat.com>
Change-Id: I46db42560ec0b93bb265f45920d78c97a32338c3
Change-Id: I274a6e5f985d60d1ae6fc929af3eb0fdcea868ba
Subsequent commits fix the errors
Warning in build.properties will be errors when they run in the tycho build, like this: ``` Error: Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:2.7.5:package-plugin (default-package-plugin) on project org.eclipse.cdt.core.tests: /home/runner/work/cdt/cdt/core/org.eclipse.cdt.core.tests/build.properties: bin.includes value(s) [test.xml] do not match any files. -> [Help 1] ``` So make them errors in the workspace so that the issue is detected before push. Some build.properties issues don't affect the build, but are still indicative of a problem.
When a more complete implementation of ANSI Escape sequence for renaming terminal titles was added in [CDT 10.2](https://github.com/eclipse-cdt/cdt/blob/main/NewAndNoteworthy/CDT-10.2.md#rename-terminal-tab) it caused a regression in use cases where extenders of the terminal wanted to retain control of the terminal's title. This commit adds a new flag that will prevent the title of the terminal tab from being updated from ANSI escape sequences. Fixes eclipse-platform#494
* remove invalid tycho resolver config (not valid since many versions) * fix PMD plugin configuration (config attribute was renamed in 3.18) * remove duplicate versions already managed in pluginManagement section * fix indentation * move all not yet configured versions into pluginManagement of the parent module to avoid further duplication * consume the target platform as file, not as maven artifact (this simplifies building a single module A LOT) * remove invalid tycho-source-plugin configuration * disable tycho consumer POM generation (not needed here, and avoids a warning in each module) * remove prerequisites. that's for maven plugins only, and this POM already contains the better suited similar maven enforcer rule * enforce UTF-8 for javadoc generation (the build fails on Windows otherwise, trying to read some Japanese? characters with the Windows default encoding)
Beta versions of maven plugins are omitted from this upgrade. A new version of Tycho brings in an update ECJ which means some of the class files are different, hence the need to bump versions of bundles too. A new calendar year brings an update to Copyrights
Using: ``` mvn org.eclipse.tycho.extras:tycho-version-bump-plugin:4.0.12:update-manifest ``` and then multiple iterations to bump the bundle-version: ``` mvn verify org.eclipse.tycho:tycho-versions-plugin:4.0.12:bump-versions -Dtycho.bump-versions.increment=100 -DskipDoc=true -DskipTests=true -P baseline-compare-and-replace -fae -Djgit.dirtyWorkingTree-cdtDefault=warning ``` Make sure bounds of all dependencies match what we built against. This prevents issues such as Bug 536448 from recurring. In 2025-06 there are a number of Eclipse Platform changes that make CDT susceptible to these types of issues again. Note that this change is similar to previous iterations, such as 1087dc5f2255b8befa31e6e0cf98e72d9483ceed, but with the automatation we can now apply this to *all* bundles. In addition, with the tighter version constraints, building from simrel repo for the jniheader (releng/scripts/do_rebuild_natives.sh) is no longer sufficient. This speedup has been removed as it was probably incorrect to have by default. The api filters were introduced because some bundles are re-exported. Those re-exported bundle requirements mean that technically we need to bump the version, but in reality we effectively required the range as now documented anyway, so doing a major version bump is unneeded.
Since M3 was published, platform had upped version of org.eclipse.core.runtime. See eclipse-cdt/cdt#1165 (comment)
Contributor
Author
|
We need to enable merge-commits for this (FYI @HannesWell ) |
Contributor
Author
|
To make the migration smooth, CDT should merge this before the next release: |
Contributor
laeubi
force-pushed
the
migrate_org.eclipse.tm.terminal.view.core
branch
from
d44a459 to
b58cea0
Compare
laeubi
force-pushed
the
migrate_org.eclipse.tm.terminal.view.core
branch
from
b58cea0 to
65e8aae
Compare
Contributor
Author
|
I now recovered as much of the history as possible (dating back 11 years) and adjusted it to the codebase so this should be ready to be merged. |
laeubi
force-pushed
the
migrate_org.eclipse.tm.terminal.view.core
branch
from
3f604f0 to
edde892
Compare
Member
|
I'm totally deferring this one to @jonahgraham as it needs changes in cdt too. |
Contributor
Author
|
Looking at the history there seem to be not much changes, so one option would be to start clean and not migrate the history at all WDYT? |
Contributor
|
Nice to see the terminal moved to platform. Thanks @laeubi for this work. Is their an issue describing the background of this change? |
Contributor
|
There's this N&N entry now: https://eclipse.dev/eclipse/markdown/?f=news/4.37/platform.md |
Contributor
This code has been moved around so much in the past that key parts of its history are missing from the history. I would recommend copying the current CDT HEAD commit for these bundles and make a reference to CDT's commit sha1 to keep tracking the history farther back. FTR this code originated in TCF, was moved to TM and then CDT before ending up here. |
Contributor
Author
Done in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrate another part of the terminal code currently in CDT to platform:
https://github.com/eclipse-cdt/cdt/tree/main/terminal/plugins/org.eclipse.tm.terminal.view.core
FYI @jonahgraham @akurtakov once this is merged and M1 is available CDT would want to use the platform M1 repo and remove the plugin from CDT. I increased the version of the bundle to 4.11 to account for the location change.