Upgrade all remaining Eclipse Platform Icons to SVG#1998
Upgrade all remaining Eclipse Platform Icons to SVG#1998HeikoKlare merged 1 commit intoeclipse-platform:masterfrom Michael5601:Include-SVGs
Conversation
Michael5601
changed the title
Should be process this PR independent from the Eclipse logo so that we do not depend on how fast we conclude on the logo SVG? |
The discussion for the eclipse logo is now finished.
|
|
Is someone aware of the location of the SVG for the icon "eclipse_lg.png" in the about dialog? 
This icon is probably the last important SVG that is missing in Eclipse Platform/Platform UI after this PR is merged. |
I think there is no SVG for this. I think these icons are created by the eclipse marketing team (together with the splash screen). See for example https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5332 and https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3963 |
Thanks for this info! I don't see a reason why they don't provide vector graphics. I am pretty sure a graphics designer creates the screens in a vector based graphics programm like it's industry standard. Maybe this should be considered in upcoming releases. |
|
@Michael5601 while this probably works, it seems a bit questionable to me, such graphics usually requires a very dense set of effects (some might be rendered) and we then need to make sure the jsvg support all these with good quality. |
|
I understand your concern and I agree that JSVG needs to rasterize them properly so it would be necessary to implement a check in the design process. Overall I think it depends on the current design process if vector graphics can be used. If the galaxy pictures in the background are created from scratch rather then being downloaded and reused, they could also be directly created as vector graphics. This level of complexity should be possible with vector graphics, even though I don't know how other programs handle the creation and scaling of such pictures. Right now the splash screen or about dialog can appear blurry if upscaled, especially if only one size is used (as done with the image |
|
I would suggest we simply ask. Even for something like this page, I would have preferred an SVG over a huge png: https://www.eclipse.org/setups/notification/release/ That pages uses this (huge version of splash) which was an image in that issue: This suggests that likely the source was an SVG... |
The huge image is kinda blurry which is why I think no SVG exists and it was simply upscaled. A comment from Holger Voormann in this thread implies that imageupscaler.com was used. But of course asking would be best. :) |
Yes I agree. Let's ask and try if we can get better here. But maybe this should not hold back this PR from being merged. |
|
Sure an SVG is nice, but from an IP point of view there is a difference in giving out a rendered version (binary) or "the source". One might even use Fonts not installed on the system or images not allowed to give away "as is" (e.g. backgrounds of commercial sold images) and so on. So this should really be communicated early if SVG is mandatory and what features are acceptable to use in such case. |
|
FYI - eclipse.platform repo got new gif files, see for example org.eclipse.terminal.view.ui |
we should not use GIFs any more. |
afaik the new bundle was created by @jonahgraham. I thought the GIFs were only work-in-progress and eventually SVGs would be added. Can you tell if this is planned? If not, I can add |
|
FYI @laeubi I think we could definitely use help converting gifs to svg for all the migrated terminal stuff. So yes, please help! ❤️ |
|
I have not further checked these but don't see a reason to not replace them with proper svg. |
I will soon work full-time on different projects apart from eclipse and additionally I want to contribute open-source to the modern icon pack initiative that I started. In the past months I tried to contribute as many SVGs for existing icons as I can to the Eclipse projects and in the end I restricted it to Eclipse Platform and Platform UI for time reasons. For the other projects I tried to document all missing SVGs in this issue. Additionally I plan to contribute a best practice/tutorial on how to create SVGs for Eclipse soon, as some people stated on the Eclipse Community Day that this would be helpful. |
|
I split the changes for the Eclipse Logo into the following draft as further discussion is needed. The stripes in the middle of the Eclipse Logo need to be alligned pixel perfect and must be 1.0px in height as proposed. This stands in conflict with the stripes being in the middle of the icon at (y = 5.5px). To find the best solution without hindering the progress of this PR I created a new draft for the Eclipse Logo. |
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Thank you, @Michael5601! The icons and changes look overall good to me.
Just one remark/question: the classes.svg icon looks like an icon that is to be used for composition. There is space to the right/bottom, where, e.g. in the package explorer additional overlay icons are placed. The original classes.gif in the affected bundle does not have such a space (as it was probably not used within an icon composition). So should/could we adapt the SVG to fill the whole icon size or does it make sense to keep the proposed version of the icon?
I copied the But for consistency reasons I propose to change the This is the end result that is now part of this PR: |
This commit changes the usage of all remaining PNGs and GIFs in Eclipse Platform to SVG. In detail the following changes were performed: 1. Include missing SVGs for existing GIFs in bundle `org.eclipse.core.tools.resources`. All SVGs were either copied from other bundles or created from scratch by myself. 2. Enabling the image comparison of mutliple SVGs with each other. 3. Changing the reference of two JFace PNGs in bundle `org.eclipse.team.ui` to SVG.
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
The updated classes.svg looks fine, thank you!
@laeubi is handling the migration of terminal work from CDT project to Platform. The gifs in terminal have been around for a very long time as the terminal bundles keep bouncing between projects, hopefully the platform is the best long term place. Your work on making svgs are greatly appreciated! |
Replacement with SVGs is already done 🙂 |
|
When I see all the people involved making this better, I too like @jonahgraham am truly impressed. |
7 participants
This PR changes the usage of all remaining PNGs and GIFs in Eclipse Platform to SVG. Currently this is a draft as I also want to include the Eclipse-Logo SVG to Eclipse Platform as soon as this issue is done.
In detail the following changes will be performed:
org.eclipse.core.tools.resources. All SVGs were either copied from other bundles or created from scratch by myself.org.eclipse.team.uito SVG.eclipse16.svg,eclipse32.svgetc. and changing the references to SVG. This allows better scaling for the window icon in the top left and the icons in the About dialog.