-
Notifications
You must be signed in to change notification settings - Fork 147
Support for modifying source in compare clipboard editor #2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SougandhS
wants to merge
3
commits into
eclipse-platform:master
Choose a base branch
from
SougandhS:compareClipboardModify
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support for modifying source in compare clipboard editor #2007
SougandhS
wants to merge
3
commits into
eclipse-platform:master
from
SougandhS:compareClipboardModify
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One more thing I have to handle |
My.Movie2.mp4 |
ac391fe
to
37ce6af
Compare
Hi @iloveeclipse, I have added the missing modify functionality 👍 |
a0b6cee
to
a089065
Compare
@iloveeclipse I think you suggest that @SougandhS adds this. Can you review? |
a089065
to
cf4f3d5
Compare
tomaswolf
reviewed
Aug 3, 2025
team/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/ClipboardCompare.java
Outdated
Show resolved
Hide resolved
cf4f3d5
to
443d921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1862 (comment)
follow-up to #1862
Supports modifying the source from compare editor itself
My.Movie.mp4