Both command.id and override.command should't reference a command id#2011
Merged
merks merged 1 commit intoeclipse-platform:masterfrom Jul 6, 2025
Merged
Both command.id and override.command should't reference a command id#2011merks merged 1 commit intoeclipse-platform:masterfrom
merks merged 1 commit intoeclipse-platform:masterfrom
Conversation
Contributor
merks
commented
Jul 5, 2025
merks
commented
- Both allow a serialized command and the override.command even allows a pattern so validation produces warnings for those usages because they are expecting on a simple id reference to a command.
merks
force-pushed
the
pr-quicklinks-schema
branch
from
d4f6967 to
99c7ccf
Compare
- Both allow a serialized command and the override.command even allows a pattern so validation produces warnings for those usages because they are expecting only a simple id reference to a command.
merks
force-pushed
the
pr-quicklinks-schema
branch
from
99c7ccf to
0043bac
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.