[Debug] Update breakpoint icon

[SougandhS]

This PR changes the dark breakpoint icon to lighter one to provide more visibility

Before

After

Fixes : eclipse-jdt/eclipse.jdt.debug#731

[SougandhS]

Hi @iloveeclipse
Could you please check this too..

[github-actions]

Test Results

 1 947 files  ±0   1 947 suites  ±0   1h 30m 50s ⏱️ - 6m 51s
 4 720 tests ±0   4 696 ✅ ±0   24 💤 ±0  0 ❌ ±0 
14 160 runs  ±0  13 993 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 7a79121. ± Comparison against base commit 401d483.

♻️ This comment has been updated with latest results.

[vogella]

Look good to me, could you also upload before / after for the light theme?

[SougandhS]

Look good to me, could you also upload before / after for the light theme?

Actually on mac child eclipse in light theme is not rendered properly (On every Eclipse versions)😕

[vogella]

Look good to me, could you also upload before / after for the light theme?

Actually on mac child eclipse in light theme is not rendered properly (On every Eclipse versions)😕

I think you need to restart child window after the theme switch. Did you try that?

[SougandhS]

I think you need to restart child window after the theme switch. Did you try that?

Yes, I did tried that but no use.

[vogella]

I think you need to restart child window after the theme switch. Did you try that?

Yes, I did tried that but no use.

@BeckerWdf is this the same to you? Runtime light Eclipse theme is broken on Mac?

[vogella]

Old icon in light theme

New icon in light theme

Looks fresher for me. WDYT? @Michael5601 @HeikoKlare @BeckerWdf ?

[HeikoKlare]

I have to admit that I am not in favor of the proposed change yet. Here are some opinions/thoughts on this:

• I (personally) don't like the new color, but that might be because I am used to the existing color and maybe it's also because of how that new color looks like on my monitors (note that a color looks different depending on the color representation/profile of your monitor).
• I am not sure whether the proposal is the right solution for the actual issue; the reported issue Bad contrast for breakpoint icon eclipse-jdt/eclipse.jdt.debug#731 is about the breakpoint icon not being well visible on top of the blue selection gutter. That selection gutter is code-rendered, so it would also be possible to adapt that gutter to the theme color. Maybe that could also improve visibility of that gutter (and of the breakpoint icons everyone is used to at the same time).
• When changing the color of such a central icon, we should thoroughly think about the proper color to choose and not just select an arbitrary other color. How was the proposed color selected? Is it just a rather arbitrary lighter blue color? Does it fit to anything else in the IDE / in existing icons? Taking a look at other IDEs (IntelliJ, VS Code), using red dots for breakpoints seems to be common there. Maybe this would be a chance to adapt. I don't think the breakpoint icon color is a USP or distinguishing element from other IDEs, so that might be a chance to align to common colors.
• There is a bunch of other icons related to breakpoints, which include the color of the breakpoint icon (several of them in the same bundle, maybe also others in other bundles). Shouldn't they be adapted at the same time so that they fit together? E.g.,
  
  

[merks]

I agree with @HeikoKlare. My first reaction is kind of like "that's weird, the color that is familiar for the last 25 years has changed to some strange new color". It just doesn't seem to "fit" with other colors and not clear how this will "fit in" overall.

[SougandhS]

Taking a look at other IDEs (IntelliJ, VS Code), using red dots for breakpoints seems to be common there. Maybe this would be a chance to adapt.

Bp with red icon would look like this (can be modified with different red saturations)

There is a bunch of other icons related to breakpoints, which include the color of the breakpoint icon (several of them in the same bundle, maybe also others in other bundles). Shouldn't they be adapted at the same time so that they fit together?

Absolutely, if the change is approved, I’m ready to put in the effort for that.

[BeckerWdf]

I agree with Ed and Heiko. We should not change that icon. But fix the issue via other ways.
There are also lot's of downstream solutions that have own icons based on the Eclipse break point icon. These would also need to adapt - and that probably will not happen.