[Debug] Prompt when launching debug session with 'Skip All Breakpoints' enabled #2114
Conversation
|
Hi @iloveeclipse |
| * | ||
| * @since 3.19 | ||
| */ | ||
| public class SkipBreakpointsWarning extends Dialog { |
There was a problem hiding this comment.
I believe you have just implemented MessageDialogWithToggle again?
There was a problem hiding this comment.
But MessageDialogWithToggle supports only 1 toggle option, so created a custom one
There was a problem hiding this comment.
Why do we need two options? Just warn and user can enable or disable "skip breakpoints" after that if needed.
There was a problem hiding this comment.
I thought this approach would help the user quickly disable the option if needed. But I can go with your suggestion
There was a problem hiding this comment.
Also you could provide a push button for the disable disabled action so that there is no expectation that the check state might be persisted like the don’t ask again check box.
There was a problem hiding this comment.
Also you could provide a push button for the disable disabled action so that there is no expectation that the check state might be persisted like the don’t ask again check box
You mean remove the checkbox and add a "disable" button right ?
There was a problem hiding this comment.
Yes. Just keep in mind that the double negative on disable the disable all is also a potential point of confusion. Enable Breakpoints might be better. The opinions of others would be welcome.
There was a problem hiding this comment.
@merks
How about this ?
There was a problem hiding this comment.
Yes that seems fine (to me).
This looks like a yet another implementation of |
SougandhS
force-pushed
the
SkipBreakpointsPrompt
branch
from
5ec22c9 to
7ae8b24
Compare
This commit adds a warning prompt when User launch application in debug mode with `Skip All Breakpoints` enabled
SougandhS
force-pushed
the
SkipBreakpointsPrompt
branch
from
7ae8b24 to
36eae5c
Compare
This pull request introduces a warning dialog that appears when a user attempts to start a debug session while the "Skip All Breakpoints" option is enabled. The goal is to prevent confusion caused by breakpoints being silently ignored, which often leads users to believe the debugger is malfunctioning.
eg https://www.reddit.com/r/eclipse/comments/13zt4ll/debugger_not_working/
eg https://bugs.eclipse.org/bugs/show_bug.cgi?id=578000
The popup will provide option to disable the warning forever (which can be enabled later on from Run/Debug settings) and option disable skip
This will be helpful for new users who may not understand the debug settings and could get confused when breakpoints don’t work as expected.
SkipBpPrmpt.mp4